-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null Pointer Exception on CustomTabsManagerActivity.onResume #2818
Comments
@Mohammed-Amleh This one is strange. Would you have any data on these crashes to determine if Google Play Services is available on these devices? This looks to be the most common scenario that can cause this. Would you happen to know if these devices are rooted? If neither of these pieces of info are available, please post a few of the devices that have crashed with this info and we can see if we notice any patterns (ex: manufacturer, OS version, etc) How many devices/users have you seen this issue on? |
@tylerjroach the crash appear for 18 users , and i don't think its Google Play Services Availability |
@Mohammed-Amleh Is this a new app, or a crash that has appeared out of nowhere on an older app? Asking because we don't see any occurrences before May 3-4 on that chart. Can you post any Amplify/AWS related code that you have added to your manifest, as well as show how you are launching signInWithWebUI or signInWithSocialWebUI sign ins? |
no its not a new app ,we was using amplify v1 ,, this error appear after upgrading to amplify v2 .
|
@Mohammed-Amleh The block you posted is no longer needed in Amplify v2. Regardless, this wouldn't impact your application. Would you happen to know if these devices are eventually able to sign in or not? Curious if it is a transient issue for them or these devices failing 100% of time time. Do the devices failing all seem to be specific to a single region? Looking for any more data points that could help identity why this may be happening. I've not seen this report before. I think I can try/catch to prevent the crash, but the scenario happening here should not be happening. A try/catch would still prevent hosted ui sign in from working correctly. The crash appears to be the CustomTab intent is null on the first launch (which shouldn't happen since it created and passed directly when calling startActivity on the CustomTabsManagerActivity. |
Have you already tested this to work? In some places we launch with
This should never happen. We never launch without intent data. This was just meant to be a safety mechanism. We don't always pass I'm still concerned about this analytics package that is injecting into our owned activities. Can we look into which library this is? Maybe there is a way to exclude individual activities. This is a headless activity ands its behavior is not meant to be modified by the app developer, nor any other 3rd party libraries. We are open to work around this 3rd party issue, but would want to test with this analytics library ourselves to make sure that any fix we attempt to create does not result in any adverse side effects elsewhere. |
@tylerjroach
but in v2 |
CustomTabsManagerActivity is intended to remain internal and should not be invoked by anything other than Amplify itself. I'd like to look at the Analytics library in question and see exactly what is being done, to make sure that we have a stable and complete way of handling unintended outside interference. |
Before opening, please confirm:
Language and Async Model
Java, Kotlin
Amplify Categories
Authentication
Describe the bug
#1090 exactly the same as this problem & the amplify version that i am using is
v2.14.6
, i cant re-produce the problem i counter it on firebase crashlytic.error :
The text was updated successfully, but these errors were encountered: