Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin github actions by commit hash #2648

Merged
merged 9 commits into from
Dec 14, 2023
Merged

Conversation

ankpshah
Copy link
Contributor

@ankpshah ankpshah commented Dec 8, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

*Description of changes: Pin github actions by commit hash.

Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Reference: Security hardening for GitHub Actions

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ankpshah ankpshah requested a review from a team as a code owner December 8, 2023 00:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Merging #2648 (3bd0af5) into main (1bfe8e0) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2648      +/-   ##
==========================================
- Coverage   41.81%   41.80%   -0.01%     
==========================================
  Files         902      902              
  Lines       28996    28996              
  Branches     4107     4107              
==========================================
- Hits        12124    12123       -1     
- Misses      15543    15544       +1     
  Partials     1329     1329              

tylerjroach
tylerjroach previously approved these changes Dec 8, 2023
tjleing
tjleing previously approved these changes Dec 8, 2023
@ankpshah ankpshah dismissed stale reviews from tjleing and tylerjroach via 0c796e5 December 8, 2023 22:09
tjleing
tjleing previously approved these changes Dec 8, 2023
tjleing
tjleing previously approved these changes Dec 9, 2023
Copy link
Contributor

@tjleing tjleing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preliminary approval. would be nice to actually understand why the tests are failing

@ankpshah ankpshah force-pushed the chore/pin-action-commit-id branch from faae143 to 649df09 Compare December 12, 2023 22:20
@ankpshah ankpshah merged commit ebd8565 into main Dec 14, 2023
6 checks passed
@ankpshah ankpshah deleted the chore/pin-action-commit-id branch December 14, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants