-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marionette behaviors #88
Comments
it would also be convenienent to have the marionette modelEvents, collectionEvents etc. |
i dont call for any change, since its a Backbone Plugin, i'm rather looking for advice to customize Backbone.Modal to accept Marionette.View instead of Backbone.View |
The project website talks about usage within Marionette, which to me implies that when using Marionette it would extend Marionette's view rather than Backbone's view. So I guess contrary to @elgubenis comment above, I do humbly ask for a change :) Perhaps provide an optional Thanks again for the awesome plugin. |
I guess I'm in the same boat, I was thinking on Creating a VIewCollection, but it won't work due to the hardcoded backbone.view dependency |
FWIW, I'm not thrilled with the fact that this plugin directly extends from const MyView = SomeArbitraryBackboneView.extend({
initialize() {
// Add methods/properties for modal behavior:
Backbone.Modal.mixin(this);
}
// ...
}); I'd have to think some more about the specifics (for example, how dealing with naming conflicts should work), but my gut tells me such an approach should work and doesn't necessitate breaking changes. |
hey, first off.. we use backbone.modal really a lot, its so easy and has so much awesomeness, we build everything with marionette, so we are using the marionette region version of backbone.modal, I would like to know if anybody of the contributors sees an easy way to have marionette behaviors possible to define inside a new modal view, i saw that the Backbone.Modal https://github.com/awkward/backbone.modal/blob/master/src/backbone.modal.coffee#L10 extends from Backbone.View, i tried to extend from Marionette.ItemView and Marionette.LayoutView but could not make it work. any ideas?
The text was updated successfully, but these errors were encountered: