Upgrade to Avo 3 #2044
Upgrade to Avo 3 #2044
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 195ca1a and detected 34 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,8 +1,8 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class Avo::Fields::BelongsToField::EditComponent < Avo::Fields::EditComponent | |||
| def initialize(**args) | |||
| super(**args) | |||
| def initialize(...) | |||
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Lint/Syntax: unexpected token tDOT3
| end | ||
| end | ||
|
|
||
| def singular_name | ||
| name | ||
| def hydrate(...) |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Lint/Syntax: unexpected token tDOT3
| class << self | ||
| def encrypt(message:, purpose:) | ||
| new(message: message, purpose: purpose).encrypt | ||
| def encrypt(...) |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Lint/Syntax: unexpected token tDOT3
| end | ||
|
|
||
| def decrypt(message:, purpose:) | ||
| new(message: message, purpose: purpose).decrypt | ||
| def decrypt(...) |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Lint/Syntax: unexpected token tDOT3
| } | ||
|
|
||
| connect() { | ||
| const vm = this; |
| const vm = this; | ||
|
|
||
| tippy(vm.context.element, { | ||
| content: "loading...", |
| @@ -0,0 +1,15 @@ | |||
| /* eslint-disable camelcase */ | |||
| import { StreamActions } from '@hotwired/turbo' | |||
There was a problem hiding this comment.
🚫 [eslint] <import/no-extraneous-dependencies> reported by reviewdog 🐶
'@hotwired/turbo' should be listed in the project's dependencies. Run 'npm i -S @hotwired/turbo' to add it
|
|
||
| // TODO: move these to the avo_filters gem | ||
|
|
||
| StreamActions.close_filters_dropdown = function () { |
There was a problem hiding this comment.
Unexpected unnamed function.
| document.querySelector('.filters-dropdown-selector').classList.add('hidden') | ||
| } | ||
|
|
||
| StreamActions.open_filter = function () { |
There was a problem hiding this comment.
Unexpected unnamed function.
| './app/views/**/*.html.erb', | ||
| './app/helpers/**/*.rb', | ||
| './app/javascript/**/*.js', | ||
| ] |
There was a problem hiding this comment.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
| ] | |
| ], |
| 850: '#232629', | ||
| 900: '#17191C', | ||
| } | ||
| const preset = require('./tailwind.preset.js') |
There was a problem hiding this comment.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Unexpected use of file extension "js" for "./tailwind.preset.js"
| const defaultTheme = require('tailwindcss/defaultTheme') | ||
|
|
||
| const { primary, blue, gray } = require('./tailwind.custom') | ||
| const avoPath = require('child_process').execSync('bundle show avo', { encoding: 'utf-8' }).trim() |
There was a problem hiding this comment.
🚫 [eslint] <import/order> reported by reviewdog 🐶child_process import should occur before import of ./tailwind.custom
| cursor: ['responsive', 'disabled'], | ||
| }, | ||
| plugins: [ | ||
| require('@tailwindcss/forms'), |
There was a problem hiding this comment.
🚫 [eslint] <global-require> reported by reviewdog 🐶
Unexpected require().
| }, | ||
| plugins: [ | ||
| require('@tailwindcss/forms'), | ||
| require('@tailwindcss/typography'), |
There was a problem hiding this comment.
🚫 [eslint] <global-require> reported by reviewdog 🐶
Unexpected require().
|
This PR has been merged into Please check the release guide for more information. |
Description
The big PR. The upgrade to Avo 3.
Avo 2 to Avo 3 upgrade guide.
Checklist:
Manual review steps
bin/devManual reviewer: please leave a comment with output from the test if that's the case.