Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up latest commits from IOHK fork #6

Open
EncodePanda opened this issue Feb 2, 2023 · 4 comments
Open

Pick up latest commits from IOHK fork #6

EncodePanda opened this issue Feb 2, 2023 · 4 comments

Comments

@EncodePanda
Copy link

Things like input-output-hk@0c9ff65.

By the way, why is IOHK version still maintained? cc: @avieth

@avieth
Copy link
Owner

avieth commented Feb 2, 2023

Marcin and Damian brought some patches over in 2022.

Things like input-output-hk@0c9ff65

Just had a quick look and it seems like that's the only thing in the IOHK fork that's not here. Would be happy to bring it over.

@EncodePanda
Copy link
Author

I will be happy to do the PR.

@erikd
Copy link

erikd commented May 14, 2023

@EncodePanda Please, please, please bring over the IOG changes [0]. I would really like to kill the IOG version.

[0]: Having two packages (one on Hackage and on in our repos) with the same name, defining some of the same module names but not being 100% compatible is proving to be a HUGE pain in the neck (for us at IOG). I have attemped to rename our version from contra-tracer to iog-contra-tracer and then attempting to propagate the changes through our stack has shown itself to be way more difficult than expected.

@erikd
Copy link

erikd commented May 14, 2023

I have looked at pulling over the changes, but I do not even have an idea of what I am looking at.

At the lowest level I get errors like:

     • Couldn't match expected type ‘Control.Tracer.Arrow.TracerA
                                      m a ()’
                  with actual type ‘a -> m ()’
    • The lambda expression ‘\ x -> traceWith (fan x) x’

The code looks like this:

fanning
  :: forall m a
  . (a -> Tracer m a) -> Tracer m a
fanning fan = Tracer $ \x -> traceWith (fan x) x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants