Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New possible error with Julia 1.10-beta2 #559

Closed
kbarros opened this issue Aug 18, 2023 · 1 comment
Closed

New possible error with Julia 1.10-beta2 #559

kbarros opened this issue Aug 18, 2023 · 1 comment

Comments

@kbarros
Copy link

kbarros commented Aug 18, 2023

After upgrading to Julia 1.10-beta2 I am seeing a new error in @report_opt that looks like an avoidable false positive:

using JET

function offsetc(cell::CartesianIndex{3}, ncells, latsize)
    CartesianIndex(mod1.(Tuple(cell) .+ Tuple(ncells), latsize))
end

cell = CartesianIndex(1,2,3)
ncells = (3,2,4)
latsize = (10,11,1)
@report_opt offsetc(cell, ncells, latsize)

Prints:

═════ 1 possible error found ═════
┌ offsetc(cell::CartesianIndex{3}, ncells::Tuple{Int64, Int64, Int64}, latsize::Tuple{Int64, Int64, Int64}) @ Main /Users/kbarros/Desktop/scratch.jl:84
│┌ materialize(bc::Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(mod1), Tuple{Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(+), Tuple{Tuple{Int64, Int64, Int64}, Tuple{Int64, Int64, Int64}}}, Tuple{Int64, Int64, Int64}}}) @ Base.Broadcast ./broadcast.jl:903
││┌ copy(bc::Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(mod1), Tuple{Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(+), Tuple{Tuple{Int64, Int64, Int64}, Tuple{Int64, Int64, Int64}}}, Tuple{Int64, Int64, Int64}}}) @ Base.Broadcast ./broadcast.jl:1115
│││┌ axes(bc::Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(mod1), Tuple{Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(+), Tuple{Tuple{Int64, Int64, Int64}, Tuple{Int64, Int64, Int64}}}, Tuple{Int64, Int64, Int64}}}) @ Base.Broadcast ./broadcast.jl:234
││││┌ _axes(bc::Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(mod1), Tuple{Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(+), Tuple{Tuple{Int64, Int64, Int64}, Tuple{Int64, Int64, Int64}}}, Tuple{Int64, Int64, Int64}}}, ::Nothing) @ Base.Broadcast ./broadcast.jl:236
│││││┌ combine_axes(A::Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(+), Tuple{Tuple{Int64, Int64, Int64}, Tuple{Int64, Int64, Int64}}}, B::Tuple{Int64, Int64, Int64}) @ Base.Broadcast ./broadcast.jl:524
││││││┌ broadcast_shape(::Tuple{Base.OneTo{Int64}}, ::Tuple{Base.OneTo{Int64}}) @ Base.Broadcast ./broadcast.jl:543
│││││││┌ _bcs(shape::Tuple{Base.OneTo{Int64}}, newshape::Tuple{Base.OneTo{Int64}}) @ Base.Broadcast ./broadcast.jl:549
││││││││┌ _bcs1(a::Base.OneTo{Int64}, b::Base.OneTo{Int64}) @ Base.Broadcast ./broadcast.jl:555
│││││││││┌ string(::String, ::Int64, ::String, ::Int64) @ Base ./strings/io.jl:189
││││││││││┌ print_to_string(::String, ::Int64, ::String, ::Int64) @ Base ./strings/io.jl:146
│││││││││││┌ kwcall(::@NamedTuple{sizehint::Int64}, ::Type{IOBuffer}) @ Base ./iobuffer.jl:106
││││││││││││┌ IOBuffer(; read::Bool, write::Bool, append::Nothing, truncate::Bool, maxsize::Int64, sizehint::Int64) @ Base ./iobuffer.jl:122
│││││││││││││┌ IOBuffer(data::Vector{UInt8}; read::Bool, write::Bool, append::Bool, truncate::Bool, maxsize::Int64, sizehint::Nothing) @ Base ./iobuffer.jl:101
││││││││││││││┌ setproperty!(x::IOBuffer, f::Symbol, v::Int64) @ Base ./Base.jl:40
│││││││││││││││ runtime dispatch detected: convert(%5::Union{Type{Vector{UInt8}}, Type{Bool}}, v::Int64)::Bool
││││││││││││││└────────────────────

Tested on JET v0.8.10 and

julia> versioninfo()
Julia Version 1.10.0-beta2
Commit a468aa198d0 (2023-08-17 06:27 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: macOS (arm64-apple-darwin22.4.0)
  CPU: 8 × Apple M1 Pro
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, apple-m1)
  Threads: 6 on 6 virtual cores
Environment:
  JULIA_EDITOR = code
  JULIA_NUM_THREADS = 5
@aviatesk
Copy link
Owner

Thanks for your report! Fixed in 0.8.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants