Updated dalek dependecy #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moraesjeremias
requested changes
Jul 2, 2024
| @@ -31,7 +31,7 @@ thiserror = { version = "1.0", optional = true } | |||
| # ECIES dependencies | |||
| ed25519-dalek = { version = "2.1", optional = true } | |||
| x25519-dalek = { version = "2.0", optional = true, features = ["static_secrets"] } | |||
| curve25519-dalek = { version = "4.1.1", optional = true } | |||
| curve25519-dalek = { version = "4.1.3", optional = true } | |||
There was a problem hiding this comment.
Gonna make a temp release based on your branch and see if these are still propagated through the consumed packages in bridge-api.
If not we can live with it till we prioritize the other vulnerabilities fix present in Cargo.lock versioned crates.
There was a problem hiding this comment.
Cargo.toml on both bridge-api and avail-core were modified to consume polkadot-1.7.1-patch-8-tmp.
On bridge-api:
╰─$ cargo audit
Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
Loaded 630 security advisories (from /home/moraesjeremias/.cargo/advisory-db)
Updating crates.io index
Scanning Cargo.lock for vulnerabilities (578 crate dependencies)
Crate: curve25519-dalek
Version: 3.2.0
Title: Timing variability in `curve25519-dalek`'s `Scalar29::sub`/`Scalar52::sub`
Date: 2024-06-18
ID: RUSTSEC-2024-0344
URL: https://rustsec.org/advisories/RUSTSEC-2024-0344
Solution: Upgrade to >=4.1.3On avail-core:
╰─$ cargo audit
Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
Loaded 630 security advisories (from /home/moraesjeremias/.cargo/advisory-db)
Updating crates.io index
Scanning Cargo.lock for vulnerabilities (459 crate dependencies)
Crate: curve25519-dalek
Version: 3.2.0
Title: Timing variability in `curve25519-dalek`'s `Scalar29::sub`/`Scalar52::sub`
Date: 2024-06-18
ID: RUSTSEC-2024-0344
URL: https://rustsec.org/advisories/RUSTSEC-2024-0344
Solution: Upgrade to >=4.1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.