Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge UI(tests): Testing workflow #51

Closed
2 tasks
abheektripathy opened this issue Aug 16, 2024 · 4 comments
Closed
2 tasks

Bridge UI(tests): Testing workflow #51

abheektripathy opened this issue Aug 16, 2024 · 4 comments
Assignees

Comments

@abheektripathy
Copy link
Member

abheektripathy commented Aug 16, 2024

we should have unit tests running on the core bridging and claim flow. They should be run on every pr to verify the new changes aren't breaking any older flows.

Hooks we're targeting as of now --

  • useBridge.tsx
  • useClaim.tsx~~
@abheektripathy abheektripathy self-assigned this Aug 16, 2024
@abheektripathy abheektripathy changed the title Bridge UI(tests): add unit testing to core bridging/claiming hooks Bridge UI(tests): Testing workflow Aug 23, 2024
@abheektripathy
Copy link
Member Author

abheektripathy commented Aug 23, 2024

according to the discussion yesterday, just writing unit tests wouldn't help in itself, here's how the testing workflow should go-

  • setup winston / logger, add logs where required
  • setup a simple dashboard to display those logs @moraesjeremias
  • setup monitors based on if a / few particular error see spikes

will be tracked in a new issue considering the work.

@moraesjeremias
Copy link
Member

Report

  • A tmp dashboard was set to report error and general bridge UI client side metrics

Blockers

  • Current env label is wrong. Needs to troubleshoot it and find root cause.

PRs:

@moraesjeremias
Copy link
Member

Report

  • The labeling issue root cause was that NODE_ENV is an enum that only takes <test|development|production> values. Switched to NEXT_PUBLIC_ENVIRONMENT to have more flexibility/fine grain control.

Contract

Agreed with @abheektripathy the following log env label values:

production -> Main Branch
staging -> Staging Branch
test -> Preview Branch
local -> Local branch (uncommited changes)

PRs:

@abheektripathy
Copy link
Member Author

@moraesjeremias marking this as done, since we have the monitors setup for failed claims, writing tests using nightwatch would be tracked in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants