remove state commit on disconnect #3385
Conversation
| if err := vm.state.Commit(); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
if we want to we can move this to SetPreference (or some periodic go routine like mempool pruning etc). I'd imagine block acceptance should be sufficient enough though.
There was a problem hiding this comment.
Another thing you can do is to check when was the last time you committed the disconnected nodes. If it's less than, say, 1 second ago, then not commit.
There was a problem hiding this comment.
yea good idea we could do that instead. but I slightly think that state should be commited with respect to chain progress.
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Why this should be merged
Committing state adds an overhead on peer disconnects
How this works
Removes state commit from disconnect. Block acceptance/Shutdown should be sufficient for writing disk to the state.
How this was tested
existing UTs should cover this