remove len check for cache test

ava-labs · Oct 16, 2024 · 95c10a3 · 95c10a3
1 parent f8470b2
commit 95c10a3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/network/p2p/acp118/handler.go b/network/p2p/acp118/handler.go
@@ -85,7 +85,7 @@ func (h *Handler) AppRequest(
 
 	msgID := msg.ID()
 	if signatureBytes, ok := h.signatureCache.Get(msgID); ok {
-		return responseBytesFromSignature(signatureBytes)
+		return signatureToResponse(signatureBytes)
 	}
 
 	if err := h.verifier.Verify(ctx, msg, request.Justification); err != nil {
@@ -101,10 +101,10 @@ func (h *Handler) AppRequest(
 	}
 
 	h.signatureCache.Put(msgID, signature)
-	return responseBytesFromSignature(signature)
+	return signatureToResponse(signature)
 }
 
-func responseBytesFromSignature(signature []byte) ([]byte, *common.AppError) {
+func signatureToResponse(signature []byte) ([]byte, *common.AppError) {
 	response := &sdk.SignatureResponse{
 		Signature: signature,
 	}

diff --git a/network/p2p/acp118/handler_test.go b/network/p2p/acp118/handler_test.go
@@ -126,10 +126,9 @@ func TestHandler(t *testing.T) {
 
 				require.True(bls.Verify(pk, signature, request.Message))
 
-				if tt.cacher.Len() > 0 {
-					// Ensure the cache is populated with correct signature
-					sig, ok := tt.cacher.Get(unsignedMessage.ID())
-					require.True(ok)
+				// Ensure the cache is populated with correct signature
+				sig, ok := tt.cacher.Get(unsignedMessage.ID())
+				if ok {
 					require.Equal(sig, response.Signature)
 				}
 			}