-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): using frenet planner to generate lane change path when ego near terminal #9767
base: main
Are you sure you want to change the base?
feat(lane_change): using frenet planner to generate lane change path when ego near terminal #9767
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4cae773
to
11e2774
Compare
66b4fe2
to
881afe1
Compare
6453e15
to
3253f79
Compare
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/path.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/path.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md
Outdated
Show resolved
Hide resolved
const LineString2d & lane_boundary, const Direction direction) | ||
{ | ||
const auto distance = (0.5 * common_data_ptr->bpp_param_ptr->vehicle_width + 0.1); | ||
const auto offset = sign<double>(direction) * distance; // invert direction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking, when doing left lane change then we want to offset to the right, and vice versa. Is that correct? Does this logic do that?
ab53673
to
5a4a82c
Compare
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
5a4a82c
to
b48770f
Compare
Signed-off-by: Zulfaqar Azmi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9767 +/- ##
==========================================
- Coverage 29.41% 29.35% -0.06%
==========================================
Files 1446 1448 +2
Lines 108365 108731 +366
Branches 42232 42462 +230
==========================================
+ Hits 31872 31921 +49
- Misses 73408 73720 +312
- Partials 3085 3090 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This PR adds frenet planner to generate candidate path when ego is near terminal.
Related launcher's PR. autowarefoundation/autoware_launch#1290
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
ROS Parameter Changes
Additions and removals
trajectory.th_prepare_curvature
double
0.03
frenet.enable
bool
0.03
frenet.th_yaw_diff
bool
10.0
frenet.th_curvature_smoothing
bool
0.1
Effects on system behavior
None.