-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_tensorrt_common): multi-TensorRT compatibility & tensorrt_common as unified lib for all perception components #9762
Conversation
…nsorrt_common as unified lib for all perception components Signed-off-by: Amadeusz Szymko <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Amadeusz Szymko <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9762 +/- ##
==========================================
- Coverage 29.41% 29.32% -0.09%
==========================================
Files 1446 1453 +7
Lines 108365 108551 +186
Branches 42232 42262 +30
==========================================
- Hits 31872 31832 -40
- Misses 73408 73635 +227
+ Partials 3085 3084 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
perception/autoware_tensorrt_common/include/autoware/tensorrt_common/conv_profiler.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
perception/autoware_tensorrt_common/include/autoware/tensorrt_common/tensorrt_common.hpp
Show resolved
Hide resolved
perception/autoware_tensorrt_common/include/autoware/tensorrt_common/tensorrt_common.hpp
Outdated
Show resolved
Hide resolved
perception/autoware_tensorrt_common/include/autoware/tensorrt_common/tensorrt_conv_calib.hpp
Show resolved
Hide resolved
Signed-off-by: Amadeusz Szymko <[email protected]>
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
(confirmed via logging simulator centerpoint / transfusion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amadeuszsz Thank you for your PR. I left some minor suggestions in autoware_tensorrt_common
.
perception/autoware_tensorrt_common/include/autoware/tensorrt_common/profiler.hpp
Outdated
Show resolved
Hide resolved
perception/autoware_tensorrt_common/include/autoware/tensorrt_common/conv_profiler.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Amadeusz Szymko <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Incoming TensorRT upgrade requires refactor within perception components. The new version of
autoware_tensorrt_common
library will stand as high-level TensorRT API. PR considers compatibility with current environment (TensorRT 8.6) and future upgrade (TensorRT 10.7+).This PR should be merged before TensorRT upgrade.
Related links
Parent Issue:
How was this PR tested?
A. Current environment (without dependencies upgrade).
B. New environment (with dependencies upgrade).
src/universe/external
.C. Perception evaluator TIER IV internal link
Notes for reviewers
TrtCommon
. Documentation says, They may not give the optimal performance and accuracy. As a workaround, use INT8 explicit quantization instead, therefore we might need to consider explicit quantization (during model deployment).Interface changes
None.
Effects on system behavior
None.