Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

works with electron-builder #31

Open
zh99998 opened this issue Oct 28, 2016 · 3 comments
Open

works with electron-builder #31

zh99998 opened this issue Oct 28, 2016 · 3 comments

Comments

@zh99998
Copy link

zh99998 commented Oct 28, 2016

It can't run with electron-builder dist package
Image: Imgur

in fact, this executable is in
/Users/zh99998/mycard/dist/mac/MyCard.app/Contents/Resources/app.asar.unpacked/node_modules/electron-sudo/dist/bin

notice app.asar.unpacked
during packaging, it says:
node_modules/electron-sudo is not packed into asar archive - contains executable code
and then leaves it in app.asar.unpacked under Resources root.

further more, I can't code sign my package (it will automatically done with with electron-builder before)

Signing app (identity: Developer ID Application: XIAOCHI CHEN (ZNVDEVDRX3))
Error: Command failed: codesign --sign Developer ID Application: XIAOCHI CHEN (ZNVDEVDRX3) --force --keychain /var/folders/my/m6ynh3bn6tq06h7xr3js0z7r0000gn/T/electron-builder-eH2lUj/t-d16-0.keychain /Users/travis/build/mycard/mycard/dist/mac/MyCard.app/Contents/Resources/app.asar.unpacked/node_modules/electron-sudo/dist/bin/applet.app/Contents/MacOS/applet
/Users/travis/build/mycard/mycard/dist/mac/MyCard.app/Contents/Resources/app.asar.unpacked/node_modules/electron-sudo/dist/bin/applet.app/Contents/MacOS/applet: unsealed contents present in the bundle root

seems it caused by this executable file and maybe can solved by some manually codesign command call, but I googled it for several hours and can't get it work....
I can provide a apple developer certificate if it helps to debug.

@automation-stack
Copy link
Owner

@zh99998 it's actual problem, need to investigate this

zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 4, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 4, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 4, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 4, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 4, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 5, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 7, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 7, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 7, 2016
zh99998 added a commit to mycard/electron-sudo that referenced this issue Nov 7, 2016
@automation-stack
Copy link
Owner

automation-stack commented Jul 12, 2017

@zh99998 will get support in version 5.0 with "asar-unpack" in package.json

@gniezen
Copy link

gniezen commented Aug 23, 2017

Any update on when version 5.0 will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants