Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi workspace support #106

Open
eriklieben opened this issue Aug 15, 2019 · 1 comment
Open

multi workspace support #106

eriklieben opened this issue Aug 15, 2019 · 1 comment
Labels
✨ vNext ✨ functionality for the vNext extension

Comments

@eriklieben
Copy link
Contributor

eriklieben commented Aug 15, 2019

Support multi workspaces in vs code

You can work with multiple project folders in Visual Studio Code with multi-root workspaces. This can be very helpful when you are working on several related projects at one time. For example, you might have a repository with a product's documentation which you like to keep current when you update the product source code.

more information for end users can be found here: https://code.visualstudio.com/docs/editor/multi-root-workspaces

more information on extension authoring can be found here:
https://github.com/Microsoft/vscode/wiki/Adopting-Multi-Root-Workspace-APIs

It would be nice if the Aurelia extension supports multiple workspaces by default.

This scenario can be either supported using a single language server or by using multiple language servers; one for each workspace (https://github.com/Microsoft/vscode/wiki/Adopting-Multi-Root-Workspace-APIs#single-language-server-or-server-per-folder).

It feels most logical to use one language server per workspace, so it's easier to keep the list of dependencies inside of a workspace/aurelia project separated. Otherwise, we might mix up different workspaces, and you don't want a suggestion based on different workspaces/ Aurelia2 projects. For example: get hints in workspace 1 about an Aurelia2 plugin you installed in workspace 2.

There is a sample code implementation for this, but it is using a deprecated property (params.rootUri). There is an open issue on the samples repo for this https://github.com/microsoft/vscode-extension-samples/issues/207 awaiting the response to that.

related to: #107

@eriklieben eriklieben added the ✨ vNext ✨ functionality for the vNext extension label Aug 15, 2019
@eriklieben eriklieben self-assigned this Aug 15, 2019
@eriklieben
Copy link
Contributor Author

eriklieben commented Aug 16, 2019

Sample repo with vs code workspaces for Aurelia2, Aurelia1, Angular, Vue, and React:
https://github.com/eriklieben/vscode-multi-workspace

When opening up the workspace, it should only activate the Aurelia2 plugin for the following workspaces:

  • aurelia2-esnext-default
  • aurelia2-typescript-default
  • aurelia2-esnext-dumberjs-custom
  • aurelia2-typescript-dumberjs-custom

image

eriklieben pushed a commit that referenced this issue Aug 16, 2019
@eriklieben eriklieben removed their assignment Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ vNext ✨ functionality for the vNext extension
Projects
None yet
Development

No branches or pull requests

1 participant