Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All errors are shown as warnings #157

Closed
AdamWillden opened this issue Jan 26, 2017 · 3 comments
Closed

All errors are shown as warnings #157

AdamWillden opened this issue Jan 26, 2017 · 3 comments
Labels

Comments

@AdamWillden
Copy link

AdamWillden commented Jan 26, 2017

Hi, I've just installed this plugin and firstly I want to thank you for this! I'm sure it'll save me lots of time debugging my colleagues and own code!

All of my errors seem to appear as warnings. Most other linters fail (return 1) when encountering an error and that is what I want and what I suspect this does (or should do). Issues that I believe should be errors (e.g. reportUnresolvedAccessMemberIssue) show up as warnings:

[16:35:07] WARNING: cannot find 'isSets' in type 'TagSnapshotValue' Ln 2 Col 3 \src\tag-snapshot-value.html
[16:35:07] WARNING: cannot find 'vaslue' in type 'TagSnapshot' Ln 3 Col 47 \src\tag-snapshot-value.html

EDIT

I've crossed out something I said which is wrong. Will make another issue with regards to emitting the error

@AdamWillden
Copy link
Author

FWIW i'm using gulp-aurelia-template-lint and recognise the issue may not actually belong in this repo.

@MeirionHughes
Copy link
Contributor

for now, you should be able to use your own reporter and throw an error to kill it. see: https://github.com/MeirionHughes/gulp-aurelia-template-lint/blob/master/index.js#L12

I will work in a way to change the severity of individual issues. see #158

@AdamWillden
Copy link
Author

Cheers @MeirionHughes, I think that the reporter could work for now.

I won't raise another issue as I said I would for emitting the error. But to clarify every other linter I use has an option whether or not to emit the error to kill the gulp task:

https://github.com/adametry/gulp-eslint#eslintfailonerror
https://github.com/panuhorsmalahti/gulp-tslint/blame/master/README.md#L69
https://github.com/sasstools/gulp-sass-lint#sasslintfailonerror

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants