Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample code is is flawed? Untested? #347

Closed
SolidStateLEDLighting opened this issue Jun 15, 2017 · 3 comments
Closed

Sample code is is flawed? Untested? #347

SolidStateLEDLighting opened this issue Jun 15, 2017 · 3 comments

Comments

@SolidStateLEDLighting
Copy link

SolidStateLEDLighting commented Jun 15, 2017

http://aurelia.io/hub.html#/doc/article/aurelia/dialog/latest/dialog-basics/5

Please examine the sample code on your page:

export class Prompt {
static inject = [DialogController];

constructor(controller){
this.controller = controller;
this.answer = null;

controller.settings.lock = false;
controller.settings.centerHorizontalOnly = true;

}
}

  1. You omitted the DialogController import statement.
  2. What is the member "answer" doing here? Is this a flaw or am I missing the understanding on what it is used for?
  3. Again, code on entire page will not translate to TS examples.
@EisenbergEffect
Copy link
Contributor

@PWKad Can you look at this?

@plwalters
Copy link
Contributor

The code is fine and has been tested. Please refer to the documentation if there are questions regarding return values and usage and such.

We can add an import statement no big deal. TypeScript translations welcome. Tracking at aurelia/dialog#305 , please close this issue.

@avrahamcool
Copy link
Contributor

I think this can be closed.
the link in the issue is no longer active - because this section was re-written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants