-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 24 kHz sampling rate #466
Comments
I also wonder, why we support 22,500 Hz. This seems like a typo to me, as a common sampling rate is 22,050 Hz, e.g. as used in CSS10 and LJSpeech. See also https://github.com/audiojs/sample-rate. As 24,000 Hz is close to 22,050 Hz, do you have examples for datasets stored with 24,000 Hz? |
I found a few examples myself. Seems to be that 24,000 Hz is used by TTS datasets, e.g. https://www.arxiv.org/abs/2408.06227. |
44100 / 2 is indeed 22050. 22500 is indeed probably not so relevant :-)
…On Tue, 19 Nov 2024, 08:34 Hagen Wierstorf, ***@***.***> wrote:
I also wonder, why we support 22,500 Hz. This seems like a typo to me, as
a common sampling rate is 22,050 Hz, e.g. as used in CSS10 and LJSpeech.
See also https://github.com/audiojs/sample-rate.
As 24,000 Hz is close to 22,050 Hz, do you have examples for datasets
stored with 24,000 Hz?
—
Reply to this email directly, view it on GitHub
<#466 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMZTQ5LC6NIVHRTWKCWPO32BLSW3AVCNFSM6AAAAABSAXJMKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUHA4TOMZRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yes they are used in TTS a lot but I think this is part of a more general
move from 16k to 24k.
There seems to be lots of use of neural codecs these days for other
purposes as well. E.g.
https://github.com/coqui-ai/TTS use it as well aot
…On Tue, 19 Nov 2024, 08:41 Hagen Wierstorf, ***@***.***> wrote:
I found a few examples myself. Seems to be that 24,000 Hz is used by TTS
datasets, e.g. https://www.arxiv.org/abs/2408.06227.
—
Reply to this email directly, view it on GitHub
<#466 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMZTQ64W37CFOMU7FFBLS32BLTRHAVCNFSM6AAAAABSAXJMKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUHEYTINJZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Description
We should add support for 24 kHz (24000 Hz) sampling rate across the library. This sampling rate is commonly used in various audio applications and would be a valuable addition to our supported rates.
Current State
Currently supported sampling rates:
Proposed Changes
Add 24000 Hz to:
SAMPLING_RATES
list inaudb/core/define.py
tests/test_convert.py
core
Motivation
24 kHz is a common sampling rate used in:
Implementation Notes
The changes should be straightforward as we already have the infrastructure to support different sampling rates. We just need to add the new rate to the existing list and update relevant tests and documentation.
Testing
We should verify:
Documentation
Update the sampling rate list in the documentation to include 24 kHz while maintaining the ascending order.
/label enhancement
The text was updated successfully, but these errors were encountered: