Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of core.typed? #4

Open
mfikes opened this issue Apr 27, 2018 · 1 comment
Open

Eliminate use of core.typed? #4

mfikes opened this issue Apr 27, 2018 · 1 comment

Comments

@mfikes
Copy link

mfikes commented Apr 27, 2018

The use of core.typed in clj-sockets caused some sort of AoT-related failure (see CLJS-2742) that can be worked around by having clients use the non-AoT version of ClojureScript 1.10.238 (via the :classifier "slim").

Downstream, Tubular is working around this by simply using a copy of clj-sockets that doesn't use this dependency.

I was curious if you'd be interested in having this change in clj-sockets itself (the removal of core.typed). If so, I'd be willing to put together a PR for consideration.

@EdwardIII
Copy link

Or would something like this work?

https://github.com/marick/lein-midje/pull/69/files

I see this error:

$ lein run
WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.core.typed.contract-utils, being replaced by: #'clojure.core.typed.contract-utils/boolean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants