Configure build matrix #4 #6
Conversation
There was a problem hiding this comment.
Your patch seems good. I don't know what the strategy @jubianchi has in mind but it looks correct. However, could you match the same matrix as we have here https://github.com/atoum/atoum/blob/master/.travis.yml? We still support hhvm and hhvm nightly.
| "require-dev": { | ||
| "atoum/atoum": "~2.0" | ||
| "phpspec/prophecy": "~1.5", | ||
| "atoum/atoum": "^2.0" |
There was a problem hiding this comment.
atoum/atoum is really a development dependency here. If you are using atoum and you would like this extension, atoum is already present. However, to test this extension alone, you need atoum, but as a development dependency.
There was a problem hiding this comment.
Moving atoum/atoum to the require section was part of the issue, see: #4
There was a problem hiding this comment.
@Hywan nope: in order to make composer check dependencies, extensiosn have to define atoum as a required dependency. Composer resolve dependency tree by merging the root package required and dev. required dependencies and children's required deps.
|
@Hywan we don't support HHVM: atoum does not work correctly on this engine and we do not plan to add support for it right now so it's better to simply remove it from the matrix. |
Sorry for the second pull request, but i messed up the first one :/
This should cover all requested changes.