Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inquiry About rescale_factor in SO3.py #18

Open
QuantumLab-ZY opened this issue Aug 14, 2024 · 1 comment
Open

Inquiry About rescale_factor in SO3.py #18

QuantumLab-ZY opened this issue Aug 14, 2024 · 1 comment

Comments

@QuantumLab-ZY
Copy link

Dear Developer,

I am writing to inquire about the rescale_factor = math.sqrt(length / (2 * mmax + 1)) defined in the SO3_Grid and CoefficientMappingModule classes within SO3.py. Could you please explain its purpose? Additionally, would omitting rescale_factor affect the network's equivariance?

Thank you for your assistance.

Best regards,

Yang Zhong

@yilunliao
Copy link
Member

Hi @QuantumLab-ZY

Please see my responses below:

  1. The purpose of rescale_factor.

The reason is that we only have a subset of m components (from 0 to mmax) when projecting to grids instead of having all the m components (from 0 to lmax).
Since we want the grid features to be well-normalized (i.e., std = 1 and mean = 0), we rescale the remaining m components with rescale_factor.

  1. Removing rescale_factor.

Removing it would not affect equivariance. It is similar to rescaling a feature uniformly, so equivariance will still be preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants