Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking - Changes] - podAnnotations don't support Datadog labels anymore #681

Closed
1 task done
suleyman-ableto opened this issue Oct 6, 2023 · 5 comments
Closed
1 task done

Comments

@suleyman-ableto
Copy link

Suggestion

We are having issue to pass Datadog autodiscovery annotations with the new pod Annotation changes.

podAnnotations:
  ad.datadoghq.com/jira.check_names: '["jira"]'
  ad.datadoghq.com/jira.init_configs: '[{"is_jmx": true, "collect_default_metrics":true}]'
  ad.datadoghq.com/jira.instances: '[{"host": "%%host%%","port":"9091"}]'
  ad.datadoghq.com/jira.logs: '[{"source":"jira","service":"jira"}]'

Error Message
Error: UPGRADE FAILED: YAML parse error on jira/templates/tests/test-application-status.yaml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal array into Go struct field .metadata.annotations of type string

Product

Jira

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bianchi2
Copy link
Collaborator

bianchi2 commented Oct 6, 2023

@suleyman-ableto sorry about that! #678 should fix it. Can you please try to run helm upgrade from main branch (say, with --dry-run or perhaps for real in a non prod environment)? If it works for you, we'll cut a release early next week.

@bianchi2
Copy link
Collaborator

bianchi2 commented Oct 8, 2023

@suleyman-ableto 1.16.2 is out. Can you please give it a go?

@suleyman-ableto
Copy link
Author

Thanks for working this. I will give it a try today and update you here.

@suleyman-ableto
Copy link
Author

Version 1.16.2 functions as anticipated. I can confirm that I successfully passed Datadog Integration annotations as pod annotations. Thank you for promptly implementing the fix.

@bianchi2
Copy link
Collaborator

bianchi2 commented Oct 9, 2023

@suleyman-ableto awesome, thanks for confirming it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants