new eslint rule to expand border shorthand property #1741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zesmith2
requested review from
JakeLane,
pancaspe87,
liamqma and
dddlr
as code owners
🦋 Changeset detectedLatest commit: 27c49db The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js canceled.
|
zesmith2
commented
Nov 5, 2024
| /* borderStyle borderWidth borderColor */ | ||
|
|
||
| ...packages_calls_and_imports.map(([pkg, call, imp]) => ({ | ||
| name: `borderStyle:keyword, borderWidth:px, borderColor:rgb - single property (${call}, ${imp})`, |
There was a problem hiding this comment.
spaces included in test name so it's easier to scan test names upon running
|
Moving this to AFM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Adding an eslint rule that expands
bordershorthand property into it's longhand partsborderStyle,borderWidth, andborderColor.borderproperty supportsborderStyle,borderWidthbeing in either order, andborderColoralways coming last. This rule supports this allowance, and only applies to shorthand that has all 3 properties present,e.g.
border: '1px',isn't covered in this rule.Why are we making this change?
Expanding the
borderproperty will decrease stylesheet size due to more common usages without all properties matching.PR checklist
Don't delete me!
I have...
website/