Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Actions Workflows to also run CodeQL on development branch PRs #276

Closed
atc0005 opened this issue Jul 24, 2024 · 0 comments · Fixed by #283
Closed

Update GitHub Actions Workflows to also run CodeQL on development branch PRs #276

atc0005 opened this issue Jul 24, 2024 · 0 comments · Fixed by #283
Assignees
@atc0005
Labels
bug Something isn't working CI linting
Milestone
v2.11.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Jul 24, 2024

I saw CodeQL objections to a recent webhook URL pattern when merging to the master branch, but not when merging previously to the development branch.

I want to ensure that CodeQL and various linters are running on PRs to both branches to detect potential issues as early as possible.

See also:
@atc0005 atc0005 added bug Something isn't working CI linting labels Jul 24, 2024
@atc0005 atc0005 added this to the Future milestone Jul 24, 2024
@atc0005 atc0005 self-assigned this Jul 24, 2024
@atc0005 atc0005 modified the milestones: Future, v2.11.0 Jul 24, 2024
@atc0005 atc0005 changed the title Review GitHub Actions Workflows to ensure CodeQL runs on development branch PRs Review GitHub Actions Workflows to ensure CodeQL also runs on development branch PRs Jul 24, 2024
@atc0005 atc0005 changed the title Review GitHub Actions Workflows to ensure CodeQL also runs on development branch PRs Update GitHub Actions Workflows to also run CodeQL on development branch PRs Jul 25, 2024
atc0005 added a commit that referenced this issue Jul 25, 2024
@atc0005
Update CodeQL workflow to run on dev branch PRs
d27a551 
Run CodeQL jobs for `development` branch in addition to the
current stable branch.

refs GH-276
@atc0005 atc0005 mentioned this issue Jul 25, 2024
Merged
atc0005 added a commit that referenced this issue Jul 25, 2024
@atc0005
Update CodeQL workflow to run on dev branch PRs
e8a96fe 
Run CodeQL jobs for `development` branch in addition to the
current stable branch.

refs GH-276
@atc0005 atc0005 mentioned this issue Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working CI linting
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Update CodeQL workflow to run on dev branch PRs atc0005/go-teams-notify
1 participant
@atc0005