Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SSH code from the API #13

Open
aszlig opened this issue May 16, 2014 · 4 comments
Open

Remove SSH code from the API #13

aszlig opened this issue May 16, 2014 · 4 comments
Milestone

Comments

@aszlig
Copy link
Owner

aszlig commented May 16, 2014

This really shouldn't belong to the API, so let's move it to the hetznerctl tool entirely.

Scheduled for 1.0.0, because this is a backwards-incompatible change.

@aszlig aszlig added this to the Version 1.0.0 milestone May 16, 2014
aszlig added a commit that referenced this issue May 16, 2014
This method is going to be removed from the API in the next major
version and wasn't intended to be in the API in the first place.

Prepares for addressing issue #13.

Signed-off-by: aszlig <[email protected]>
@dangra
Copy link
Contributor

dangra commented May 16, 2014

I am a user of observed_active/deactive(), what is wrong with providing such functionality as a library?

@aszlig
Copy link
Owner Author

aszlig commented May 17, 2014

Ah, sorry, wanted to change the description of this issue. Didn't remember the exact implementation of them while writing this issue. So no, those methods won't be removed, sorry for the confusion.

I'm however thinking about a new API architecture for 1.0.0, so the implementation of these methods will probably change.

@adrianog
Copy link

Maybe this warning can be removed then:
The RescueSystem.shell() method will be removed from the API in version 1.0.0, please do not use it! See https://github.com/aszlig/hetzner/issues/13 for details.

@aszlig
Copy link
Owner Author

aszlig commented Jun 20, 2020

@adrianog: Mhm, good point. What I had in mind back then was to move the function to another location. So maybe it's a good idea to move it already and change the warning to point to the new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants