From 8710f530d6588d09709a58ed22e81d8ca41c6d08 Mon Sep 17 00:00:00 2001
From: Timon Back <timonback@users.noreply.github.com>
Date: Wed, 4 Dec 2024 16:42:57 +0100
Subject: [PATCH] fix: always allow schema string examples (#1007)

Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
---
 .../ruleset/v2/functions/schemaValidation.ts  |  2 +-
 .../v2/asyncapi2-schema-examples.spec.ts      | 36 +++++++++----------
 2 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/packages/parser/src/ruleset/v2/functions/schemaValidation.ts b/packages/parser/src/ruleset/v2/functions/schemaValidation.ts
index 845a90005..6e56538b6 100644
--- a/packages/parser/src/ruleset/v2/functions/schemaValidation.ts
+++ b/packages/parser/src/ruleset/v2/functions/schemaValidation.ts
@@ -64,7 +64,7 @@ export const schemaValidation = createRulesetFunction<SchemaFragment, { type: 'd
         },
       );
 
-      if (Array.isArray(result)) {
+      if (Array.isArray(result) && typeof relevantItem.value !== 'string') {
         results.push(...result);
       }
     }
diff --git a/packages/parser/test/ruleset/rules/v2/asyncapi2-schema-examples.spec.ts b/packages/parser/test/ruleset/rules/v2/asyncapi2-schema-examples.spec.ts
index e7bd66fcd..c4edee986 100644
--- a/packages/parser/test/ruleset/rules/v2/asyncapi2-schema-examples.spec.ts
+++ b/packages/parser/test/ruleset/rules/v2/asyncapi2-schema-examples.spec.ts
@@ -43,7 +43,7 @@ testRule('asyncapi2-schema-examples', [
           parameters: {
             userId: {
               schema: {
-                examples: [17, 'one', 13],
+                examples: [17, {}, 13, 'string-is-always-accepted'],
               },
             },
           },
@@ -53,26 +53,26 @@ testRule('asyncapi2-schema-examples', [
         parameters: {
           orphanParameter: {
             schema: {
-              examples: [17, 'one', 13],
+              examples: [17, {}, 13, 'string-is-always-accepted'],
             },
           },
         },
         schemas: {
           aSchema: {
-            type: 'string',
-            examples: [17, 'one', 13],
+            type: 'object',
+            examples: [17, {}, 13, 'string-is-always-accepted'],
           },
         },
       },
     },
     errors: [
       {
-        message: '"0" property type must be string',
+        message: '"0" property type must be object',
         path: ['components', 'schemas', 'aSchema', 'examples', '0'],
         severity: DiagnosticSeverity.Error,
       },
       {
-        message: '"2" property type must be string',
+        message: '"2" property type must be object',
         path: ['components', 'schemas', 'aSchema', 'examples', '2'],
         severity: DiagnosticSeverity.Error,
       },
@@ -88,7 +88,7 @@ testRule('asyncapi2-schema-examples', [
           parameters: {
             userId: {
               schema: {
-                examples: [17, 'one', 13],
+                examples: [17, {}, 13, 'string-is-always-accepted'],
               },
             },
           },
@@ -98,26 +98,26 @@ testRule('asyncapi2-schema-examples', [
         parameters: {
           orphanParameter: {
             schema: {
-              type: 'string',
-              examples: [17, 'one', 13],
+              type: 'object',
+              examples: [17, {}, 13, 'string-is-always-accepted'],
             },
           },
         },
         schemas: {
           aSchema: {
-            examples: [17, 'one', 13],
+            examples: [17, {}, 13, 'string-is-always-accepted'],
           },
         },
       },
     },
     errors: [
       {
-        message: '"0" property type must be string',
+        message: '"0" property type must be object',
         path: ['components', 'parameters', 'orphanParameter', 'schema', 'examples', '0'],
         severity: DiagnosticSeverity.Error,
       },
       {
-        message: '"2" property type must be string',
+        message: '"2" property type must be object',
         path: ['components', 'parameters', 'orphanParameter', 'schema', 'examples', '2'],
         severity: DiagnosticSeverity.Error,
       },
@@ -133,8 +133,8 @@ testRule('asyncapi2-schema-examples', [
           parameters: {
             userId: {
               schema: {
-                type: 'string',
-                examples: [17, 'one', 13],
+                type: 'object',
+                examples: [17, {}, 13, 'string-is-always-accepted'],
               },
             },
           },
@@ -144,25 +144,25 @@ testRule('asyncapi2-schema-examples', [
         parameters: {
           orphanParameter: {
             schema: {
-              examples: [17, 'one', 13],
+              examples: [17, {}, 13, 'string-is-always-accepted'],
             },
           },
         },
         schemas: {
           aSchema: {
-            examples: [17, 'one', 13],
+            examples: [17, {}, 13, 'string-is-always-accepted'],
           },
         },
       },
     },
     errors: [
       {
-        message: '"0" property type must be string',
+        message: '"0" property type must be object',
         path: ['channels', 'users/{userId}/signedUp', 'parameters', 'userId', 'schema', 'examples', '0'],
         severity: DiagnosticSeverity.Error,
       },
       {
-        message: '"2" property type must be string',
+        message: '"2" property type must be object',
         path: ['channels', 'users/{userId}/signedUp', 'parameters', 'userId', 'schema', 'examples', '2'],
         severity: DiagnosticSeverity.Error,
       },