fix: client security scheme now works with spec v3 #588
Conversation
Souvikns
requested review from
fmvilas,
KhudaDad414 and
asyncapi-bot-eve
as code owners
There was a problem hiding this comment.
I think we should have a centtral README.md file in the root of anime-http to explain how to run this example and what it is. I see we have asyncapi.md file in the client and the server folders but I don't see any useful info there for me to get started.
src/adapters/ws/client.ts
Outdated
| @@ -51,6 +51,11 @@ class WsClientAdapter extends Adapter { | |||
| const modedAuth = await gleeAuth.processClientAuth({ url, headers, query: {} }) | |||
| headers = modedAuth.headers | |||
| url = modedAuth.url | |||
| if (modedAuth.query) { | |||
There was a problem hiding this comment.
IMO this should be handled by the auth process not in ws client. so the logic should be usable in both http and ws.
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version 0.32.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Test Coverage Report for Build 7181764316Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Pull Request Test Coverage Report for Build 6982702688Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Description
This PR aims to update the client security scheme to add support for working with spec v3.
Related issue(s)
Fixes #556