Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allcontributors PRs gets stuck #562

Closed
KhudaDad414 opened this issue Nov 1, 2023 · 4 comments · Fixed by #566
Closed

allcontributors PRs gets stuck #562

KhudaDad414 opened this issue Nov 1, 2023 · 4 comments · Fixed by #566
Labels
bug Something isn't working released

Comments

@KhudaDad414
Copy link
Member

Describe the bug

Any PR that is being added by allcontributors gets stuck and can't be merged.

example:

#560
#554
@KhudaDad414 KhudaDad414 added the bug Something isn't working label Nov 1, 2023
@Souvikns
Copy link
Member

Souvikns commented Nov 2, 2023

Only happening in this repo? It works fine in CLI, should we update allcontributors manually for now.

@KhudaDad414
Copy link
Member Author

@Souvikns I will take a look into this issue. I think the problem is with testing, test results never get reported. 🤔

@derberg
Copy link
Member

derberg commented Nov 6, 2023

it is because skip_ci info in description of PR

fix with https://github.com/asyncapi/cli/blob/master/.all-contributorsrc#L338

@KhudaDad414 KhudaDad414 mentioned this issue Nov 8, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.28.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not skip ci for allcontributors asyncapi/glee
4 participants
@derberg @KhudaDad414 @Souvikns @asyncapi-bot