Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes Unused Imports Closes #527 #528

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: removes Unused Imports Closes #527 #528

merged 1 commit into from
Oct 9, 2023

Conversation

notpritam
Copy link
Contributor

Description
PR aims to remove unused imports of import of 'MiddlewareCallback' from tests/lib/adapter.test.ts directory

Related issue(s)
Fixes #527

github-actions[bot]
github-actions bot reviewed Oct 1, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Souvikns
Copy link
Member

Souvikns commented Oct 4, 2023 •
edited
Loading

@notpritam we follow conventional commit that's why the tests are failing, just change the title of the PR accordingly and it should work.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6370694055

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.392%
Totals Coverage Status
Change from base Build 6337958553: 0.0%
Covered Lines: 360
Relevant Lines: 470
💛 - Coveralls

@notpritam notpritam changed the title Removes Unused Imports Closes #527 fix: Removes Unused Imports Closes #527 Oct 4, 2023
@notpritam notpritam changed the title fix: Removes Unused Imports Closes #527 fix: removes Unused Imports Closes #527 Oct 4, 2023
@notpritam
Copy link
Contributor Author

@notpritam we follow conventional commit that's why the tests are failing, just change the title of the PR accordingly and it should work.

Done...

KhudaDad414
KhudaDad414 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KhudaDad414
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 3aeb755 into asyncapi:master Oct 9, 2023
25 of 27 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.26.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@KhudaDad414 KhudaDad414 KhudaDad414 approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove this unused import of 'MiddlewareCallback'.
5 participants
@notpritam @Souvikns @coveralls @KhudaDad414 @asyncapi-bot