You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description
This PR continues the discussion on the glee authentication issue #377 , it continues the discussion about glee authentication, from #460 .
Following the idea from @Souvikns to use a separate directory for authentication. Each file in this directory can hold both server and client authentication logic.
In the glee root directory, cd examples/anime-http/server,
The server directory, contains an auth directory that holds a trendingAnimeServer.ts file. The file contains some logic you can edit how you like but it must export the same functions as the code above
npm run dev to start the server in dev mode
The same logic applies to the client directory, cd examples/anime-http/server
Then look for auth/trendingAnime.js update accordingly then start the server.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the discussion on the glee authentication issue #377 , it continues the discussion about glee authentication, from #460 .
Following the idea from @Souvikns to use a separate directory for authentication. Each file in this directory can hold both server and client authentication logic.
Steps to test run authentication
cd examples/anime-http/server
,auth
directory that holds atrendingAnimeServer.ts
file. The file contains some logic you can edit how you like but it must export the same functions as the code abovenpm run dev
to start the server in dev modecd examples/anime-http/server
auth/trendingAnime.js
update accordingly then start the server.Related issue(s)
Resolves #377
@Souvikns @KhudaDad414