refactor: added Prettier on entire codebase #404
Conversation
Queen-codes
requested review from
fmvilas,
Souvikns,
KhudaDad414 and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
@Queen-codes We are using node 18 for this project. can you please regenerate your package-lock.json with that version?
alright, would do this. Thank you very much |
|
Kudos, SonarCloud Quality Gate passed!
|
HI @KhudaDad414 . Already did this. Please kindly review and confirm if I need to make any changes again. |
|
@Queen-codes thanks, as I see the package-lock.json version 3 is generate which I was not expecting. 🤔 @derberg Node 18 is being shipped with npm version 9 which generates the package-lock.json version 3. |
Hi, sorry for the late reply. Is there anything I can do to help? |
|
@KhudaDad414 we didn't yet solve the problems of v1 and v2 and you are telling me there is v3 😆 |
|
hey @Queen-codes can you use node 16 to regenerate package-lock.json and resolve the conflicts? |
yeah, sure. thank you |
|
@Queen-codes The support for v3 is here and I think it's time to merge this. please let me know when you resolve the conflicts so we can merge this. thank you. 😄 |
|
Hi @Queen-codes, do you need some help here? |
|
@KhudaDad414 I will be closing this as we already added prettier and I don't see any response in this PR. |
Description
Related issue(s)