error when running npm install in glee

[KhudaDad414]

Describe the bug

After cloning glee the first step is to run npm install to install the dependencies.
With the newer version of npm you will get the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^8.6.0" from the root project
npm ERR!   peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/[email protected]
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     dev @typescript-eslint/eslint-plugin@"^5.9.0" from the root project
npm ERR!     @typescript-eslint/eslint-plugin@"^5.1.0" from [email protected]
npm ERR!     node_modules/eslint-plugin-github
npm ERR!       eslint-plugin-github@"^4.3.5" from the root project
npm ERR!   15 more (@typescript-eslint/experimental-utils, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0" from [email protected]
npm ERR! node_modules/eslint-plugin-sonarjs
npm ERR!   dev eslint-plugin-sonarjs@"^0.5.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0" from [email protected]
npm ERR!   node_modules/eslint-plugin-sonarjs
npm ERR!     dev eslint-plugin-sonarjs@"^0.5.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 

as npm suggests adding --legacy-peer-deps resolves the issue but there should be a better solution here.
maybe a package needs to be upgraded? 🤔

How to Reproduce

1. clone glee.
2. run npm i with npm 8 or higher.

Expected behavior

There shouldn't be any errors and dependencies should install.

[KhudaDad414]

/gfi js

[sambhavgupta0705]

Hey ,I would like to look into this issue

[KhudaDad414]

@sambhavgupta0705 sure. 🙇

[sambhavgupta0705]

Hey @KhudaDad414 ,resolved some erros

I think the left one are due to conflicting dev dependencies

[sambhavgupta0705]

I am using npm version 9.6.1 and node version 18.0.0

[KhudaDad414]

@sambhavgupta0705 please open A PR. we can discuss this further over there :)

[sambhavgupta0705]

Opening it

[SinghiHarsh]

@KhudaDad414 I have upgraded package versions of eslint-plugin-sonarjs & typedoc
#408

[SinghiHarsh]

Opening it

Hi @sambhavgupta0705 , I tried upgrading the package versions to fix dependency tree error,
What is your approach ?

[sambhavgupta0705]

@SinghiHarsh I had the same approach of upgrading the versions.

[rukundob451]

@KhudaDad414 @sambhavgupta0705 what was the conclusion to this is it open?

[ConnectBhawna]

Hii @KhudaDad414 @sambhavgupta0705 if no one working on this i would like to work on this issue

[ayushnau]

cant see the issue.

[sambhavgupta0705]

@ayushnau which version of npm are you using?

[Souvikns]

same here, I can't reproduce the error as well I am using npm v9.7.2 and node v20.4.0

[KhudaDad414]

tested with node v20, v18, v16 and it seems like the error doesn't show up anymore. closing the issue.