Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add support for next release branch #294

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

jonaslagoni
Copy link
Member

Description
In Modelina we have been using next since the beginning, however, we decided to remove it from the official workflow 🤨 We did a patch at some point in Modelina, and then I forgot about it.

This PR adds it officially.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg derberg changed the title feat: add next release branch ci: add support for next release branch Apr 29, 2024
@derberg
Copy link
Member

derberg commented Apr 29, 2024

don't you use also a global release config for sematic-release?
we need change in https://github.com/asyncapi/.github/blob/master/.github/workflows/.releaserc as well

@jonaslagoni
Copy link
Member Author

We dont no.

@jonaslagoni
Copy link
Member Author

In the next branch we use a much more customized version: https://github.com/asyncapi/modelina/blob/next/.releaserc

@jonaslagoni
Copy link
Member Author

I wonder if we should just remove Modelina from getting global CI change pushes...

@derberg
Copy link
Member

derberg commented Apr 29, 2024

@jonaslagoni as long as you do not provide modifications in release workflow, I do not recommend it.

release workflows are separated from release config with topics get-global-node-release-workflows and get-global-releaserc so that is fine and you have a flexibility you need at the moment. Just please update in this PR the release config, so semantic-release for others knows what to do with merges to next

@jonaslagoni
Copy link
Member Author

@derberg done ✌️

@derberg
Copy link
Member

derberg commented Apr 30, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit e6b0dd9 into asyncapi:master Apr 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants