Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from degrees to radians #45

Open
cdeil opened this issue Jan 21, 2015 · 0 comments
Open

Change from degrees to radians #45

cdeil opened this issue Jan 21, 2015 · 0 comments

Comments

@cdeil
Copy link
Member

cdeil commented Jan 21, 2015

Currently internally in the code we use angles in degrees in most places and also use this to store inputs and outputs in tables.

I think we should use radians, because that's what all coordinate packages use internally for the calculations, so if we start doing any speed benchmarking, that should be the input / output format of the data we pass in and out. Also changing to radians will get rid of a few lines of conversion code.

@astrofrog - Would you be OK with this change? I could do it now.

In any case, as mentioned by @astrofrog at #42 (comment) , we should store the angle units used in the input / output tables, e.g. by using ECSV once it's merged into Astropy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant