-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a plot and an image to the docs #307
Comments
I think perhaps snapshots of the |
FYI: I don't plan to do this in case someone else wants to. |
That sounds great. I've added a link to one ipynb in the splatalogue docs, but I think more demo notebooks would be very useful. |
@keflavich Where did you add that link? |
partway down the page at astroquery.readthedocs.org/en/latest/splatalogue/splatalogue.html. I think it should be cleaned up and moved to the Gallery |
Punting to wishlist. |
I constructed a HR diagram using Astroquery, if you want to use it in the gallery: |
@gracca I think that would be a great example! Are you be interested to turn this into a pull request for @keflavich How should the Gallery work technically? The simplest solution would probably be to commit PNG or SVG files to the repo, but there's also the option to let Sphinx make the plot and maybe even to use https://github.com/sphinx-gallery/sphinx-gallery or bokeh to get interactive plots. The main disadvantage of this is that the Sphinx build might fail from time to time when the download of the datasets doesn't work because the service isn't up. |
My Python skills are rather poor, but I'll be glad to contribute! No problems with changing the docstrings to English. I'll see how to make the pull request. |
@keflavich: Is it as simple as clonning astroquery repo and editing |
Pretty much, yeah. Unless we try one of the fancier plotting approaches
|
@keflavich - So for this case you want the PNG to be committed into the repo? |
I've never used the |
@gracca - In case you haven't used the Sphinx plot directive before, here's an example:
The drawback is that it will fail if the service isn't up ... but my suggestion would be to use it and if it turns out to be unreliable we can put the PNG or data in this repo or some other Github repo. |
Superseded by #3027 |
It would be very nice if the Astroquery gallery contained a plot (e.g. a Herzsprung-Russel-Diagram or whatever) and an image (e.g. the Galactic center region).
That's what I expected when I clicked "gallery". :-)
@keflavich If you don't want images in the repo because of the file size, then maybe an independent IPython notebook and a link to nbviewer would be better?
The text was updated successfully, but these errors were encountered: