Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyVO dependency #2958

Closed
andamian opened this issue Feb 27, 2024 · 7 comments · Fixed by #3002
Closed

Update PyVO dependency #2958

andamian opened this issue Feb 27, 2024 · 7 comments · Fixed by #3002

Comments

@andamian
Copy link

This came up in the context of #2855 which requires PyVO 1.5 that was out for a couple of months now. Is it still premature to require it?

@bsipocz bsipocz added this to the v0.4.8 milestone Feb 27, 2024
@bsipocz
Copy link
Member

bsipocz commented Mar 13, 2024

I think pyvo 1.5 is still premature to require package wide, but we can certainly bump the version a bit and also require more recent version for alma.

@andamian
Copy link
Author

Sure, if this is your strategy, although I don't see the clear benefit. Remind me please, is this just to accommodate users that pin their already installed pyvo version?

@bsipocz
Copy link
Member

bsipocz commented Mar 13, 2024

yes, this is to accommodate any users who are 1) cannot update for any reasons and 2) are not users of alma where features from a more recent pyvo is required (or irsa, as we do require 1.5 there, too)

I'm not sure how many are in this cross-section, but generally we don't require dependencies that are only a few months old.

@bsipocz
Copy link
Member

bsipocz commented May 3, 2024

OK, so I wasn't really on board with this, but now that we finally bumped support for python 3.7 and 3.8, I don't see anything else that the most recent pyvo would auto-upgrade.

So, while it's a bit orthodox, I don't see any reasons for holding back this requirement change (and in fact this would fix some of the SIA2 related issues users starting to to report when using some of the astroquery modules with an old pyvo version).

@keflavich - are you on board for requiring pyvo>=1.5?

@keflavich
Copy link
Contributor

Yes. My only concern is when installing into very old environments (CASA always packages with many years old python versions), I still want astroquery to function. But if this is solving real problems, sure, let's go ahead.

@bsipocz
Copy link
Member

bsipocz commented May 3, 2024

We already dropped the python versions here.

Could you maybe double check if python 3.9 is generally ok with them? We can dial it back to 3.8 if absolutely necessary, but keep supporting 3.7 was already became problematic

@keflavich
Copy link
Contributor

Let's not worry about supporting older versions. If astroquery happens to work when installed in those environments, great! But I don't want that to burden us or our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants