From 4d487d9acc59a89f5a2d921cb06d1edb35bfa90d Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Fri, 1 Dec 2023 16:01:52 +0000 Subject: [PATCH 01/10] Add contributor roles and names --- docs/contributing.rst | 4 +++ docs/contributors-roles.rst | 55 +++++++++++++++++++++++++++++++++++++ docs/contributors.rst | 26 ++++++++++++++++++ docs/index.rst | 3 +- 4 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 docs/contributors-roles.rst create mode 100644 docs/contributors.rst diff --git a/docs/contributing.rst b/docs/contributing.rst index f87553883..3e2ab6fe3 100644 --- a/docs/contributing.rst +++ b/docs/contributing.rst @@ -1,3 +1,5 @@ +.. _contributing: + Cosmos Contributing Guide ========================= @@ -6,6 +8,8 @@ All contributions, bug reports, bug fixes, documentation improvements, enhanceme As contributors and maintainers to this project, you are expected to abide by the `Contributor Code of Conduct `_. +Learn more about the contributors roles in :ref:`contributors-roles`. + Overview ________ diff --git a/docs/contributors-roles.rst b/docs/contributors-roles.rst new file mode 100644 index 000000000..d93b07764 --- /dev/null +++ b/docs/contributors-roles.rst @@ -0,0 +1,55 @@ +.. _contributors-roles: + +Contributors roles +================== + +Contributors are welcome and are greatly appreciated! Every little bit helps, and we give credit to them. + +This document aims to explain the current roles in the Astronomer Cosmos project. +Please check :ref:`contributing` to see our contributing guidelines. + + +Contributors +------------ + +A contributor is anyone who wants to contribute code, documentation, tests, ideas, or anything to the Astronomer Cosmos project. + +Cosmos contributors can be found in the Astronomer Cosmos Github `insights page `_ and in the `#airflow-dbt `_ Slack channel. + +Contributors are responsible for: + +* Fixing bugs +* Adding features +* Improving the documentation +* Making/answering questions in the #airflow-dbt Slack channel + + +Committers/Maintainers +---------------------- + +Committers are community members with write access to the `Astronomer Cosmos Github repository `_. +They can modify the code and the documentation and accept others' contributions to the repo. + +Check :ref:`contributors` for the official list of Astronomer Cosmos committers. + +Committers have the same responsibilities as standard contributors and also perform the following actions: + +* Reviewing & merging pull-requests +* Scanning and responding to GitHub issues, helping triaging them +* Releasing new versions of Cosmos in `PyPI `_, following the `milestones `_. +* Refactoring code +* Improving processes and tooling + +If you know you are not going to be able to contribute for a long time (for instance, due to a change of job or circumstances), you should inform other maintainers and we will mark you as "inactive". +Inactive committers will no longer have write access to the repo. +As merit earned never expires, once an inactive committer become active again, they can simply email another maintainer and ask to be reinstated. + +Pre-requisites to becoming a committer +....................................... + +General prerequisites that we look for in all candidates: + +1. Consistent contribution over last few months +2. Visibility on discussions on the Slack channel or GitHub issues/discussions +3. Contributions to community health and project's sustainability for the long-term +4. Understands the project's contributors guidelines :ref:`contributing`. diff --git a/docs/contributors.rst b/docs/contributors.rst new file mode 100644 index 000000000..52765b5f7 --- /dev/null +++ b/docs/contributors.rst @@ -0,0 +1,26 @@ +.. _contributors: +Contributors +============ + +There are different ways people can contribute to Astronomer Cosmos. +Learn more about the project contributors roles in :ref:`contributors-roles`. + +Committers/Maintainers +---------------------- + +* Harel Shein (`@harels `_) +* Julian LaNeve (`@jlaneve `_) +* Tatiana Al-Chueyr (`@tatiana `_) + + +Inactive Committers/Maintainers +------------------------------- + +* Chris Hronek (`@chrishronek `_) +* Ian Moritz (`@iancmoritz `_) + +Contributors +------------ + +Many people are improving Astronomer Cosmos each day. +Find more contributors `in our Github page `_ and in the `#airflow-dbt `_ Slack channel. diff --git a/docs/index.rst b/docs/index.rst index f5cd3673d..aa88d0ae2 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -73,7 +73,8 @@ __________________ All contributions, bug reports, bug fixes, documentation improvements, enhancements are welcome. -A detailed overview an how to contribute can be found in the `Contributing Guide `_. +A detailed overview on how to contribute can be found in the `Contributing Guide `_. +Find out more about `our contributors `_. As contributors and maintainers to this project, you are expected to abide by the `Contributor Code of Conduct `_. From 43a52b6a3e4015534c3f3a9032f5291c018b6cb7 Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Fri, 1 Dec 2023 16:05:31 +0000 Subject: [PATCH 02/10] Fix link --- docs/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.rst b/docs/index.rst index aa88d0ae2..0c7ab506c 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -74,7 +74,7 @@ __________________ All contributions, bug reports, bug fixes, documentation improvements, enhancements are welcome. A detailed overview on how to contribute can be found in the `Contributing Guide `_. -Find out more about `our contributors `_. +Find out more about `our contributors `_. As contributors and maintainers to this project, you are expected to abide by the `Contributor Code of Conduct `_. From a99577dec583eecb1f68bc18deb38e7d00621da9 Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Fri, 1 Dec 2023 16:08:39 +0000 Subject: [PATCH 03/10] Improve links --- docs/contributors-roles.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors-roles.rst b/docs/contributors-roles.rst index d93b07764..68722b378 100644 --- a/docs/contributors-roles.rst +++ b/docs/contributors-roles.rst @@ -6,7 +6,7 @@ Contributors roles Contributors are welcome and are greatly appreciated! Every little bit helps, and we give credit to them. This document aims to explain the current roles in the Astronomer Cosmos project. -Please check :ref:`contributing` to see our contributing guidelines. +For more information, check :ref:`contributing` and :ref:`contributors`. Contributors From f4a195dbaa9ee9bb31a6e8acead11c6bdc79c8e3 Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Fri, 1 Dec 2023 16:11:48 +0000 Subject: [PATCH 04/10] Fix link to ian --- docs/contributors.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors.rst b/docs/contributors.rst index 52765b5f7..9cbbc091e 100644 --- a/docs/contributors.rst +++ b/docs/contributors.rst @@ -17,7 +17,7 @@ Inactive Committers/Maintainers ------------------------------- * Chris Hronek (`@chrishronek `_) -* Ian Moritz (`@iancmoritz `_) +* Ian Moritz (`@iancmoritz `_) Contributors ------------ From d38fe40119eea6c3c0d92b0577464da67c065ed1 Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Mon, 4 Dec 2023 15:02:09 +0000 Subject: [PATCH 05/10] Apply suggestions from code review Replace inactive by emeritus. Change releases to be an Astronomer responsibility. Restore Chris as an active maintainer. Associate general contributions to general contributors (not only maintainers) --- docs/contributors-roles.rst | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/contributors-roles.rst b/docs/contributors-roles.rst index 68722b378..99ffa6679 100644 --- a/docs/contributors-roles.rst +++ b/docs/contributors-roles.rst @@ -19,6 +19,8 @@ Cosmos contributors can be found in the Astronomer Cosmos Github `insights page Contributors are responsible for: * Fixing bugs +* Refactoring code +* Improving processes and tooling * Adding features * Improving the documentation * Making/answering questions in the #airflow-dbt Slack channel @@ -36,13 +38,10 @@ Committers have the same responsibilities as standard contributors and also perf * Reviewing & merging pull-requests * Scanning and responding to GitHub issues, helping triaging them -* Releasing new versions of Cosmos in `PyPI `_, following the `milestones `_. -* Refactoring code -* Improving processes and tooling -If you know you are not going to be able to contribute for a long time (for instance, due to a change of job or circumstances), you should inform other maintainers and we will mark you as "inactive". -Inactive committers will no longer have write access to the repo. -As merit earned never expires, once an inactive committer become active again, they can simply email another maintainer and ask to be reinstated. +If you know you are not going to be able to contribute for a long time (for instance, due to a change of job or circumstances), you should inform other maintainers, and we will mark you as "emeritus". +Emeritus committers will no longer have write access to the repo. +As merit earned never expires, once an emeritus committer becomes active again, they can simply email another maintainer from Astronomer and ask to be reinstated. Pre-requisites to becoming a committer ....................................... @@ -53,3 +52,5 @@ General prerequisites that we look for in all candidates: 2. Visibility on discussions on the Slack channel or GitHub issues/discussions 3. Contributions to community health and project's sustainability for the long-term 4. Understands the project's contributors guidelines :ref:`contributing`. + +Astronomer has the right to grant and revoke write access permissions to the project's official repository for any reason it sees fit. From 950ec259f0f944848b039f0704f581a193e2acaa Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Mon, 4 Dec 2023 15:02:31 +0000 Subject: [PATCH 06/10] Update docs/contributors.rst --- docs/contributors.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/contributors.rst b/docs/contributors.rst index 9cbbc091e..a757ee21f 100644 --- a/docs/contributors.rst +++ b/docs/contributors.rst @@ -8,6 +8,7 @@ Learn more about the project contributors roles in :ref:`contributors-roles`. Committers/Maintainers ---------------------- +* Chris Hronek (`@chrishronek `_) * Harel Shein (`@harels `_) * Julian LaNeve (`@jlaneve `_) * Tatiana Al-Chueyr (`@tatiana `_) From ea2ab811da5e0ac197a7b120a67fda591f6ed41d Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Mon, 4 Dec 2023 15:03:47 +0000 Subject: [PATCH 07/10] Update docs/contributors.rst --- docs/contributors.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/contributors.rst b/docs/contributors.rst index a757ee21f..6d80a2587 100644 --- a/docs/contributors.rst +++ b/docs/contributors.rst @@ -14,11 +14,10 @@ Committers/Maintainers * Tatiana Al-Chueyr (`@tatiana `_) -Inactive Committers/Maintainers +Emeritus Committers/Maintainers ------------------------------- -* Chris Hronek (`@chrishronek `_) -* Ian Moritz (`@iancmoritz `_) +(none at the moment) Contributors ------------ From 82db500dff42958dbc9168cb10d9890696ecdd40 Mon Sep 17 00:00:00 2001 From: Harel Shein Date: Mon, 4 Dec 2023 10:04:17 -0500 Subject: [PATCH 08/10] releases by astronomer only --- docs/contributors-roles.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors-roles.rst b/docs/contributors-roles.rst index 99ffa6679..ce03b99f1 100644 --- a/docs/contributors-roles.rst +++ b/docs/contributors-roles.rst @@ -52,5 +52,5 @@ General prerequisites that we look for in all candidates: 2. Visibility on discussions on the Slack channel or GitHub issues/discussions 3. Contributions to community health and project's sustainability for the long-term 4. Understands the project's contributors guidelines :ref:`contributing`. - +Astronomer is responsible and accountable for releasing new versions of Cosmos in PyPI , following the milestones . Astronomer has the right to grant and revoke write access permissions to the project's official repository for any reason it sees fit. From a55a48bcbb31b819f2cb0d53a31b973a037705c5 Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Mon, 4 Dec 2023 15:38:16 +0000 Subject: [PATCH 09/10] Apply suggestions from code review Address @jlaneve feedback Co-authored-by: Julian LaNeve --- docs/contributors-roles.rst | 4 ++-- docs/contributors.rst | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/contributors-roles.rst b/docs/contributors-roles.rst index ce03b99f1..7cddfb95f 100644 --- a/docs/contributors-roles.rst +++ b/docs/contributors-roles.rst @@ -1,6 +1,6 @@ .. _contributors-roles: -Contributors roles +Contributor roles ================== Contributors are welcome and are greatly appreciated! Every little bit helps, and we give credit to them. @@ -26,7 +26,7 @@ Contributors are responsible for: * Making/answering questions in the #airflow-dbt Slack channel -Committers/Maintainers +Committers ---------------------- Committers are community members with write access to the `Astronomer Cosmos Github repository `_. diff --git a/docs/contributors.rst b/docs/contributors.rst index 6d80a2587..85e4cbe40 100644 --- a/docs/contributors.rst +++ b/docs/contributors.rst @@ -5,7 +5,7 @@ Contributors There are different ways people can contribute to Astronomer Cosmos. Learn more about the project contributors roles in :ref:`contributors-roles`. -Committers/Maintainers +Committers ---------------------- * Chris Hronek (`@chrishronek `_) From 897d34b2f8e76698afe33fdfdfb4e77fcf7078a5 Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Mon, 4 Dec 2023 15:41:50 +0000 Subject: [PATCH 10/10] Update docs/contributors.rst Co-authored-by: Julian LaNeve --- docs/contributors.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors.rst b/docs/contributors.rst index 85e4cbe40..273358d3c 100644 --- a/docs/contributors.rst +++ b/docs/contributors.rst @@ -14,7 +14,7 @@ Committers * Tatiana Al-Chueyr (`@tatiana `_) -Emeritus Committers/Maintainers +Emeritus Committers ------------------------------- (none at the moment)