Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the arg dbt_project_path set in the ProjectConfig init optional #569

Closed
tatiana opened this issue Sep 29, 2023 · 5 comments · Fixed by #581
Closed

Make the arg dbt_project_path set in the ProjectConfig init optional #569

tatiana opened this issue Sep 29, 2023 · 5 comments · Fixed by #581
Labels
good first issue Good for newcomers
Milestone
1.3.0

Comments

@tatiana
Copy link
Collaborator

tatiana commented Sep 29, 2023

Context

Currently, users must declare the dbt_project_path argument when instantiating ProjectConfig (

astronomer-cosmos/cosmos/config.py

Line 57 in 0123c3e

dbt_project_path: str | Path
).

However, this variable should not be needed when rendering DAGs using a dbt manifest (LoadMode.DBT_MANIFEST). This is particularly relevant if users do not want to have their dbt pipelines together with the Airflow DAGs code, which should already be possible if they are using ExecutionMode.KUBERNETES.

Proposal

Make the dbt_project_path argument optional when instantiating ProjectConfig.

This ticket relates to #568 and it is also a follow-up to a conversation with @pgoslatara
@tatiana tatiana added this to the 1.3.0 milestone Sep 29, 2023
@tatiana tatiana changed the title Make ProjectConfig.dbt_project_path optional Make the argument dbt_project_path set in the ProjectConfig initialization optional Sep 29, 2023
@tatiana tatiana changed the title Make the argument dbt_project_path set in the ProjectConfig initialization optional Make the argument dbt_project_path set in the ProjectConfig init optional Sep 29, 2023
@tatiana tatiana changed the title Make the argument dbt_project_path set in the ProjectConfig init optional Make the arg dbt_project_path set in the ProjectConfig init optional Sep 29, 2023
@tatiana tatiana added the good first issue Good for newcomers label Oct 5, 2023
@tatiana
Copy link
Collaborator Author

tatiana commented Oct 5, 2023

Discussed in the #airflow-dbt channel:
https://apache-airflow.slack.com/archives/C059CC42E9W/p1696308262251219

@MrBones757
Copy link
Contributor

I was discussing this in the slack thread linked above, and will attempt to work on the implementation of this.

@MrBones757 MrBones757 mentioned this issue Oct 9, 2023
Merged
2 tasks
@erdos2n
Copy link
Contributor

erdos2n commented Oct 9, 2023

@tatiana can I take this issue?

@tatiana
Copy link
Collaborator Author

tatiana commented Oct 9, 2023

Hi @erdos2n , thanks for offering to help! I think @MrBones757 is working on this: #581

tatiana pushed a commit that referenced this issue Oct 13, 2023
@MrBones757
Make the arg dbt_project_path in the ProjectConfig optional (#581)
5ae38f6 
This change allows the `dbt_project_path` argument from `ProjectConfig` to
be optional, and add the ability to provide `manifest_path` alone. It
also adds the ability for the user to (optionally) define `project_name`
when `dbt_project_path` is defined and requires `project_name` to be
defined when `dbt_project_path` is not defined.

Closes: #569
@tatiana
Copy link
Collaborator Author

tatiana commented Oct 13, 2023

This was released as part of 1.2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Make the arg dbt_project_path in the ProjectConfig optional
3 participants
@tatiana @MrBones757 @erdos2n