-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dbt project parsing/Airflow DAG rendering for load_method=LoadMode.CUSTOM
#561
Comments
This issue happen because the implementaion of astronomer-cosmos/cosmos/dbt/parser/project.py Lines 344 to 347 in 4c8d6b0
|
Thank you very much, @raffifu ! I appreciate your contributions. This issue has been there for a while, and the fact the coverage in this part of the code is limited certainly didn't help us surface it before. Please, reach out if you're not able to look into this, and I'll check it out - otherwise, the ticket is yours 🎁 |
This was released as part of 1.2: |
As part of testing for the 1.1.2 release (#560), we realised that if the DAG uses
load_method=LoadMode.CUSTOM
, all the test nodes are removed from the DAG.Example DAG, run from the Cosmos repo (dev/dags):
Rendered DAG with
load_method=LoadMode.DBT_LS
:Same DAG rendered with
load_method=LoadMode.CUSTOM
:This issue is a bug in the current implementation of Cosmos custom parsing of dbt projects, highlighted since we introduced #543.
Acceptance criteria
load_method=LoadMode.CUSTOM
The text was updated successfully, but these errors were encountered: