diff --git a/NEWS.md b/NEWS.md index a97c25b6..ac6edab2 100644 --- a/NEWS.md +++ b/NEWS.md @@ -11,33 +11,34 @@ one. The major changes include: * Reversed the direction of the inequality equations `hin` and `hinjac` in the wrapper functions which use them, bringing them into compliance with the main `nloptr` call. This addresses -[Issue #148](https://github.com/astamm/nloptr/issues/148). +[Issue #148](https://github.com/astamm/nloptr/issues/148); * Cleaned the Hock-Schittkowski problem no. 100, Hartmann 6-dimensional, and Powell exponential examples. This addresses [Issue #152](https://github.com/astamm/nloptr/issues/152) and -[Issue #156](https://github.com/astamm/nloptr/issues/156). -* Updated roxygen version. -* Updated maintainer email. -* Deal with NA returns from detectCords (contributed by @jeroen in PR #150); -* Setup rhub v2 checks. -* Update cmake installation instructions on Mac with brew (#146). -* Allow use of equality constraints with COBYLA (#135). +[Issue #156](https://github.com/astamm/nloptr/issues/156); +* Updated roxygen version; +* Updated maintainer email; +* Deal with NA returns from `parallel::detectCores()` (contributed by @jeroen in +PR #150); +* Setup rhub v2 checks; +* Update cmake installation instructions on Mac with brew (#146); +* Allow use of equality constraints with COBYLA (#135); * Replaced the unit testing framework of `testthat` with `tinytest` (See -[Issue #136](https://github.com/astamm/nloptr/issues/136)). +[Issue #136](https://github.com/astamm/nloptr/issues/136)); * Brought coverage of `is.nloptr` to 100%. The only file not completely covered by unit tests is `nloptr.c`. The uncovered calls are error messages which get -trapped by tests in R before the call gets to C. -* Linted package for code correctness and consistency. -* Updated vignette, DESCRIPTION, and NEWS. -* Updated package website to use bootstrap 5. -* Expanded unit tests: coverage now over 97% with no file below 90% -* Removed forcing `C++11` -* Added safety checks to C code -* Added many safety and efficiency enhancements to R code -* Most R code style made self-consistent +trapped by tests in R before the call gets to C; +* Linted package for code correctness and consistency; +* Updated vignette, DESCRIPTION, and NEWS; +* Updated package website to use bootstrap 5; +* Expanded unit tests: coverage now over 97% with no file below 90%; +* Removed forcing `C++11`; +* Added safety checks to C code; +* Added many safety and efficiency enhancements to R code; +* Most R code style made self-consistent; * Updated documentation and messages for accuracy and mathematical formatting -* Updated Github actions -* Some bugfixes (e.g. in `isres` or the warning in `nl.grad`.) +* Updated Github actions; +* Some bugfixes (e.g. in `isres` or the warning in `nl.grad`). Please see the commit logs for more detailed descriptions of the changes. diff --git a/cran-comments.md b/cran-comments.md index 81bbb647..45beadab 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -8,25 +8,20 @@ strategy * ubuntu 22.04 latest release using the *reuse existing build of nlopt* strategy -* [win-builder](https://win-builder.r-project.org/) (release and devel) -* [macOS-builder](https://mac.r-project.org/macbuilder/submit.html) NOTHING TO DO +* [win-builder](https://win-builder.r-project.org/) (release and devel) NOTHING TO DO +* [macOS-builder](https://mac.r-project.org/macbuilder/submit.html) CHECKER BROKEN * [R-hub](https://builder.r-hub.io) - - Windows Server 2022, R-devel, 64 bit - - Ubuntu Linux 22.04.1 LTS, R-release, GCC - - Fedora Linux, R-devel, clang, gfortran - - Debian Linux, R-devel, GCC ASAN/UBSAN + - All R versions on GitHub Actions ubuntu-latest + - All R versions on GitHub Actions macos-13 + - All R versions on GitHub Actions macos-latest + - All R versions on GitHub Actions windows-latest + - R Under development (unstable) (2024-06-14 r86747) on Ubuntu 22.04.4 LTS + ghcr.io/r-hub/containers/clang-asan:latest ## R CMD check results There was no ERROR and no WARNINGs. -There were 2 NOTEs: - - * checking installed package size ... NOTE - installed size is 12.2Mb - sub-directories of 1Mb or more: - libs 11.8Mb - -The size varies according to the system on which the package is installed. +There was 1 NOTE: * New maintainer: Aymeric Stamm @@ -35,15 +30,17 @@ The size varies according to the system on which the package is installed. This is a change of email address. The maintainer is the same person. - * checking for detritus in the temp directory ... NOTE - Found the following files/directories: - 'lastMiKTeXException' - -This NOTE appears only on Windows. - ## Downstream dependencies -We checked 118 reverse dependencies (111 from CRAN + 7 from Bioconductor), -comparing R CMD check results across CRAN and dev versions of this package. + +We checked 145 reverse dependencies (136 from CRAN + 9 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. * We saw 0 new problems - * We failed to check 0 packages + * We failed to check 3 packages + +Issues with CRAN packages are summarised below. + +### Failed to check + +* smam (NA) +* spaMM (NA) +* surveyvoi (NA) diff --git a/revdep/README.md b/revdep/README.md index c8f53e3a..9ba44ee6 100644 --- a/revdep/README.md +++ b/revdep/README.md @@ -1,55 +1,32 @@ # Platform -|field |value | -|:--------|:-----------------------------------------------| -|version |R version 4.1.1 (2021-08-10) | -|os |macOS Monterey 12.2.1 | -|system |aarch64, darwin20.6.0 | -|ui |RStudio | -|language |(EN) | -|collate |en_US.UTF-8 | -|ctype |en_US.UTF-8 | -|tz |Europe/Paris | -|date |2022-05-02 | -|rstudio |2022.06.0-daily+333 Spotted Wakerobin (desktop) | -|pandoc |NA | +|field |value | +|:--------|:----------------------------------------| +|version |R version 4.4.0 (2024-04-24) | +|os |macOS Sonoma 14.5 | +|system |aarch64, darwin20 | +|ui |RStudio | +|language |(EN) | +|collate |en_US.UTF-8 | +|ctype |en_US.UTF-8 | +|tz |Europe/Paris | +|date |2024-06-19 | +|rstudio |2024.04.2+764 Chocolate Cosmos (desktop) | +|pandoc |NA | # Dependencies -|package |old |new |Δ | -|:----------|:------|:------|:--| -|nloptr |2.0.0 |2.0.1 |* | -|brio |1.1.3 |1.1.3 | | -|callr |3.7.0 |3.7.0 | | -|cli |3.3.0 |3.3.0 | | -|crayon |1.5.1 |1.5.1 | | -|desc |1.4.1 |1.4.1 | | -|diffobj |0.3.5 |0.3.5 | | -|digest |0.6.29 |0.6.29 | | -|ellipsis |0.3.2 |0.3.2 | | -|evaluate |0.15 |0.15 | | -|fansi |1.0.3 |1.0.3 | | -|glue |1.6.2 |1.6.2 | | -|jsonlite |1.8.0 |1.8.0 | | -|lifecycle |1.0.1 |1.0.1 | | -|magrittr |2.0.3 |2.0.3 | | -|pillar |1.7.0 |1.7.0 | | -|pkgconfig |2.0.3 |2.0.3 | | -|pkgload |1.2.4 |1.2.4 | | -|praise |1.0.0 |1.0.0 | | -|processx |3.5.3 |3.5.3 | | -|ps |1.7.0 |1.7.0 | | -|R6 |2.5.1 |2.5.1 | | -|rematch2 |2.1.2 |2.1.2 | | -|rlang |1.0.2 |1.0.2 | | -|rprojroot |2.0.3 |2.0.3 | | -|rstudioapi |0.13 |0.13 | | -|testthat |3.1.4 |3.1.4 | | -|tibble |3.1.6 |3.1.6 | | -|utf8 |1.2.2 |1.2.2 | | -|vctrs |0.4.1 |0.4.1 | | -|waldo |0.4.0 |0.4.0 | | -|withr |2.5.0 |2.5.0 | | +|package |old |new |Δ | +|:-------|:-----|:-----|:--| +|nloptr |2.0.3 |2.1.0 |* | # Revdeps +## Failed to check (3) + +|package |version |error |warning |note | +|:---------|:-------|:-----|:-------|:----| +|smam |0.7.2 |1 | | | +|spaMM |4.5.0 |1 | |1 | +|surveyvoi |1.0.6 |1 | |1 | + diff --git a/revdep/cran.md b/revdep/cran.md index ea15c373..3104012e 100644 --- a/revdep/cran.md +++ b/revdep/cran.md @@ -1,7 +1,14 @@ ## revdepcheck results -We checked 118 reverse dependencies (111 from CRAN + 7 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. +We checked 145 reverse dependencies (136 from CRAN + 9 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. * We saw 0 new problems - * We failed to check 0 packages + * We failed to check 3 packages +Issues with CRAN packages are summarised below. + +### Failed to check + +* smam (NA) +* spaMM (NA) +* surveyvoi (NA) diff --git a/revdep/email.yml b/revdep/email.yml index c018b7fd..0d72f962 100644 --- a/revdep/email.yml +++ b/revdep/email.yml @@ -1,6 +1,7 @@ -release_date: 2021-12-20 +my_version: 2.0.3 +release_date: 2024-06-15 rel_release_date: 2 weeks my_news_url: https://github.com/astamm/nloptr/blob/master/NEWS.md -release_version: 2.0.0 -release_details: The biggest change is that we now rely on CMake for building - systematically the latest version (2.7.1) of the NLopt library. +release_version: 2.1.0 +release_details: The biggest change is that we now rely on tinytest instead of + testthat for unit testing. diff --git a/revdep/failures.md b/revdep/failures.md index 9a207363..0772b1d7 100644 --- a/revdep/failures.md +++ b/revdep/failures.md @@ -1 +1,217 @@ -*Wow, no problems at all. :)* \ No newline at end of file +# smam + +
+ +* Version: 0.7.2 +* GitHub: https://github.com/ChaoranHu/smam +* Source code: https://github.com/cran/smam +* Date/Publication: 2024-01-10 21:30:02 UTC +* Number of recursive dependencies: 64 + +Run `revdepcheck::revdep_details(, "smam")` for more info + +
+ +## In both + +* checking whether package ‘smam’ can be installed ... ERROR + ``` + Installation failed. + See ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/smam/new/smam.Rcheck/00install.out’ for details. + ``` + +## Installation + +### Devel + +``` +* installing *source* package ‘smam’ ... +** package ‘smam’ successfully unpacked and MD5 sums checked +** using staged installation +checking for gsl-config... no +configure: error: gsl-config not found, is GSL installed? +ERROR: configuration failed for package ‘smam’ +* removing ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/smam/new/smam.Rcheck/smam’ + + +``` +### CRAN + +``` +* installing *source* package ‘smam’ ... +** package ‘smam’ successfully unpacked and MD5 sums checked +** using staged installation +checking for gsl-config... no +configure: error: gsl-config not found, is GSL installed? +ERROR: configuration failed for package ‘smam’ +* removing ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/smam/old/smam.Rcheck/smam’ + + +``` +# spaMM + +
+ +* Version: 4.5.0 +* GitHub: NA +* Source code: https://github.com/cran/spaMM +* Date/Publication: 2024-06-09 22:20:02 UTC +* Number of recursive dependencies: 103 + +Run `revdepcheck::revdep_details(, "spaMM")` for more info + +
+ +## In both + +* checking whether package ‘spaMM’ can be installed ... ERROR + ``` + Installation failed. + See ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/spaMM/new/spaMM.Rcheck/00install.out’ for details. + ``` + +* checking package dependencies ... NOTE + ``` + Packages which this enhances but not available for checking: + 'multcomp', 'RLRsim', 'lmerTest' + ``` + +## Installation + +### Devel + +``` +* installing *source* package ‘spaMM’ ... +** package ‘spaMM’ successfully unpacked and MD5 sums checked +** using staged installation +** libs +using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.3.9.4)’ +using SDK: ‘MacOSX14.4.sdk’ +clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/Rcpp/include' -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/RcppEigen/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c COMPoisson.cpp -o COMPoisson.o +clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/Rcpp/include' -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/RcppEigen/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c PLS.cpp -o PLS.o +In file included from PLS.cpp:1: +In file included from ./spaMM_linear.h:4: +... + ^ +5 warnings generated. +clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/Rcpp/include' -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/RcppEigen/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c newBessel.cpp -o newBessel.o +newBessel.cpp:2:10: fatal error: 'gsl/gsl_sf_bessel.h' file not found +#include + ^~~~~~~~~~~~~~~~~~~~~ +1 error generated. +make: *** [newBessel.o] Error 1 +ERROR: compilation failed for package ‘spaMM’ +* removing ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/spaMM/new/spaMM.Rcheck/spaMM’ + + +``` +### CRAN + +``` +* installing *source* package ‘spaMM’ ... +** package ‘spaMM’ successfully unpacked and MD5 sums checked +** using staged installation +** libs +using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.3.9.4)’ +using SDK: ‘MacOSX14.4.sdk’ +clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/Rcpp/include' -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/RcppEigen/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c COMPoisson.cpp -o COMPoisson.o +clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/Rcpp/include' -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/RcppEigen/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c PLS.cpp -o PLS.o +In file included from PLS.cpp:1: +In file included from ./spaMM_linear.h:4: +... + ^ +5 warnings generated. +clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/Rcpp/include' -I'/Users/stamm-a/Softs/nloptr/revdep/library.noindex/spaMM/RcppEigen/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c newBessel.cpp -o newBessel.o +newBessel.cpp:2:10: fatal error: 'gsl/gsl_sf_bessel.h' file not found +#include + ^~~~~~~~~~~~~~~~~~~~~ +1 error generated. +make: *** [newBessel.o] Error 1 +ERROR: compilation failed for package ‘spaMM’ +* removing ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/spaMM/old/spaMM.Rcheck/spaMM’ + + +``` +# surveyvoi + +
+ +* Version: 1.0.6 +* GitHub: https://github.com/prioritizr/surveyvoi +* Source code: https://github.com/cran/surveyvoi +* Date/Publication: 2024-02-16 23:10:06 UTC +* Number of recursive dependencies: 117 + +Run `revdepcheck::revdep_details(, "surveyvoi")` for more info + +
+ +## In both + +* checking whether package ‘surveyvoi’ can be installed ... ERROR + ``` + Installation failed. + See ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/surveyvoi/new/surveyvoi.Rcheck/00install.out’ for details. + ``` + +* checking package dependencies ... NOTE + ``` + Package suggested but not available for checking: ‘gurobi’ + ``` + +## Installation + +### Devel + +``` +* installing *source* package ‘surveyvoi’ ... +** package ‘surveyvoi’ successfully unpacked and MD5 sums checked +** using staged installation +checking if R found... yes +configure: R version: 4.4.0 +checking for pkg-config... no +configure: Package PKG_CPPFLAGS: -I/opt/R/arm64/include +configure: Package PKG_LIBS: -lgmpxx -lgmp -lmpfr -lgmp +checking if gmp compiles... no +configure: Configuration failed because gmp was not found. Try installing: +... +configure: * deb: libgmp3-dev (Debian, Ubuntu) +configure: * rpm: gmp-devel (Fedora, EPEL) +configure: * brew: gmp (Mac OSX) +configure: +configure: If gmp is already installed, check that 'pkg-config' is in +configure: your PATH and PKG_CONFIG_PATH contains a gmpxx.pc file. +configure: +configure: error: ERROR: Installation failed +ERROR: configuration failed for package ‘surveyvoi’ +* removing ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/surveyvoi/new/surveyvoi.Rcheck/surveyvoi’ + + +``` +### CRAN + +``` +* installing *source* package ‘surveyvoi’ ... +** package ‘surveyvoi’ successfully unpacked and MD5 sums checked +** using staged installation +checking if R found... yes +configure: R version: 4.4.0 +checking for pkg-config... no +configure: Package PKG_CPPFLAGS: -I/opt/R/arm64/include +configure: Package PKG_LIBS: -lgmpxx -lgmp -lmpfr -lgmp +checking if gmp compiles... no +configure: Configuration failed because gmp was not found. Try installing: +... +configure: * deb: libgmp3-dev (Debian, Ubuntu) +configure: * rpm: gmp-devel (Fedora, EPEL) +configure: * brew: gmp (Mac OSX) +configure: +configure: If gmp is already installed, check that 'pkg-config' is in +configure: your PATH and PKG_CONFIG_PATH contains a gmpxx.pc file. +configure: +configure: error: ERROR: Installation failed +ERROR: configuration failed for package ‘surveyvoi’ +* removing ‘/Users/stamm-a/Softs/nloptr/revdep/checks.noindex/surveyvoi/old/surveyvoi.Rcheck/surveyvoi’ + + +``` diff --git a/revdep/run_revdepcheck.R b/revdep/run_revdepcheck.R index 7474d8f1..f906a381 100644 --- a/revdep/run_revdepcheck.R +++ b/revdep/run_revdepcheck.R @@ -1,5 +1,5 @@ revdepcheck::revdep_reset() revdepcheck::revdep_check( - num_workers = 4, + num_workers = 8, timeout = as.difftime(360, units = "mins") )