Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reward for learning strategies is calculated at the wrong place #523

Open
nick-harder opened this issue Dec 13, 2024 · 0 comments
Open

Reward for learning strategies is calculated at the wrong place #523

nick-harder opened this issue Dec 13, 2024 · 0 comments

Comments

@nick-harder
Copy link
Member

Right now the calculate_reward function is executed during set_dispatch_plan call, but this function does not reflect the dynamics of the units, these are calculated in the execute_current_dispatch function of each unit. For example for storage units, the reward is calculated before the SOC is actually updated in the execute_current_dispatch function, which leads to wrong calculations. I believe the calculate_reward as well as calculate_cashflow functions should be removed to the execute_current_dispatch functions, so we calculate the cashflow and the reward correctly when everything has been updated. @maurerle @kim-mskw what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant