Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JComboBoxFixture.selectItem() does not set focus on ComboBox #271

Open
p10n opened this issue Sep 14, 2022 · 3 comments
Open

JComboBoxFixture.selectItem() does not set focus on ComboBox #271

p10n opened this issue Sep 14, 2022 · 3 comments

Comments

@p10n
Copy link

p10n commented Sep 14, 2022

I get failing tests even though my code is fine; the test is failing because JComboBoxFixture.selectItem() does not set focus on the ComboBox (as a user action would do).

(Background info: I am relying on the focus of ComboBoxes (or any of their subcomponents) as a trick to detect whether ActionPerformed or ItemStateChanged events are "real" ones (resulting from user actions) or "superfluous" ones (that ComboBoxes tend to throw on other inappropriate occasions.)

I verified this by debug output, but also when (visually) watching the test runnning, I notice that other UI elements (e.g. buttons) get a painted focus, while the combobox does not.
My colleague @Gleethos had a look at JComboBoxDriver and JComboBoxSetSelectedIndexTask, and we think that there should be some code setting focus (like an analogon to JButton.doClick(), which does set the focus for buttons).

P.S. If this is welcome, we could try to add/fix it and create a pull-request...?

@stodge
Copy link

stodge commented Feb 8, 2024

Any update on this?

@p10n
Copy link
Author

p10n commented Feb 15, 2024

We are still using a workaround...

@scordio
Copy link
Member

scordio commented Feb 15, 2024

Hi @p10n and @stodge, apologies for the lack of feedback, we're a bit short on capacity especially for assertj-swing.

I'll reserve some time in the upcoming weeks to bring this project back to life and follow up on topics like #264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants