Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Hamcrest matchers migration support #1

Open
slinkydeveloper opened this issue Mar 21, 2022 · 0 comments
Open

Better Hamcrest matchers migration support #1

slinkydeveloper opened this issue Mar 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@slinkydeveloper
Copy link
Collaborator

Right now we only support a couple of Hamcrest matchers, but it would be nice to support more of them, in particular all the list matchers. The Hamcrest matchers migrations are a bit tedious, as to properly infer whether the migration is possible or not, one should be able to match whether the inputs of the matcher functions. Take these 2 examples:

assertThat(list, contains(element))

assertThat(list, contains(myMatcher))

In the former, we should be able to migrate to assertThat(list).contains(element), while in the latter we should fallback to the satisfies migration, as there's no way we can take that myMatcher and automatically convert it to assertj.

As a result of this task, we should have proper support for Hamcrest collections assertions

@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant