Use valid example code in the README.md #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following problems were presente with the original example: * syntax error on config dict creation * append was called on the observations list, but the params is also a list, making it a nested list and giving a `TypeError` (list indices must be integers or slices, not str) in observation_processor.py * unclear statement `import experiment`. It is not immediately evident that experiment is supposed to be a local module implementing a `run` function that takes a list of 2 dictionaries (!) with experimental parameters and returns a merit function. * There should be 1 merit function result per set of parameters, not per batch. Also params is a list so `params['obj'] = merit` should be at least `params[0]['obj'] = merit1; params[1]['obj'] = merit2`. * variable named 'iter' shadowing global scope (ok, this is not important ;) * ITER_BUDGET unset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following problems were presente with the original example:
TypeError(list indices must be integers or slices, not str) in observation_processor.pyimport experiment. It is not immediately evident that experiment is supposed to be a local module implementing arunfunction that takes a list of 2 dictionaries (!) with experimental parameters and returns a merit function.params['obj'] = meritshould be at leastparams[0]['obj'] = merit1; params[1]['obj'] = merit2.