Add a Must-Use loader file. #136
Conversation
costdev
force-pushed
the
add_mu_loader_file
branch
from
4ea1ffe to
cf78274
Compare
| /** | ||
| * MU Loader | ||
| * | ||
| * @author Andy Fragen, Colin Stewart |
There was a problem hiding this comment.
This is an externally-maintained resource used by multiple projects and being proposed for use by AspireUpdate, rather than AspireUpdate's own resource. If myself or @afragen release an update to the file, we can open an issue and PR to implement the updates for AspireUpdate.
Pinging @afragen as co-maintainer.
| * Plugin URI: https://gist.github.com/afragen/9117fd930d9be16be8a5f450b809dfa8 | ||
| * Description: Loads AspireUpdate as a Must-Use plugin. Disables normal plugin activation and deletion. | ||
| * Version: 0.6.0 | ||
| * Author: WordPress Upgrade/Install Team |
| * Author: WordPress Upgrade/Install Team | ||
| * License: MIT | ||
| * Text Domain: mu-loader | ||
| * GitHub Plugin URI: https://gist.github.com/afragen/9117fd930d9be16be8a5f450b809dfa8 |
| * Description: Loads AspireUpdate as a Must-Use plugin. Disables normal plugin activation and deletion. | ||
| * Version: 0.6.0 | ||
| * Author: WordPress Upgrade/Install Team | ||
| * License: MIT |
| * Version: 0.6.0 | ||
| * Author: WordPress Upgrade/Install Team | ||
| * License: MIT | ||
| * Text Domain: mu-loader |
| /** | ||
| * Class MU_Loader | ||
| */ | ||
| class MU_Loader { |
There was a problem hiding this comment.
Update class name to match AU Classes
|
the mu-loader can just be include(AspireUpdate/aspire-update.php); |
|
Just including the main plugin file will still allow deletion of the plugin which would allow any Administrator (or any other role with the |
|
We should also move the plugin to mu-plugins folder |
|
AspireUpdate needs to remain in the |
|
Or Lets triage and decide weather we should go this route. The main issue for me is making something MU in a not recommended way. The prescribed way is to move to mu-plugins folder and in the process make it unchangeable (no updates). If we are going to change that behavior lets make sure everyone know what they are getting into and then decide. Lets keep the PR open until a consensus is reached. |
|
Ignore the changes requested in PR until then, If we go with it, lets keep this file as a dependency and proceed instead of absorbing into the code base so that the original license and contributors are retained. |
asirota
added
documentation
|
@costdev please add docs to readme for the plugin please |
Sure, let's make sure we have consensus on the chosen path. My interpretation was that the desire for implementing a Must-Use facility in the plugin was rooted in preventing other Administrators/ |
|
@costdev @asirota What if we make this a GIST (or link to this file somewhere) and include instructions on how to do the MU switch using the GIST. That way our official repo can maintain Core recommended workflow and not mix different licenses in its code while providing a pathway for those interested to push MU this way and still have updated delivered to their plugin. |
|
@caseysoftware what do you think about making AU a "must-use" plugin and integrating code to make it so? |
Pull Request
What changed?
mu/aspireupdate-mu-loader.php.phpcs.xml.dist.Installation instructions:
AspireUpdate/mu/aspireupdate-mu-loader.phpfile intowp-content/mu-plugins/.Plugins > Installed pluginsand see that AspireUpdate is now loaded as a Must-Use plugin.Why did it change?
We wanted to add a file that made it convenient for site owners with filesystem access to load AspireUpdate as a Must-Use plugin.
Did you fix any specific issues?
Fixes #79
CERTIFICATION
By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.