Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider environment variable equivalents for some constants #149

Open
costdev opened this issue Nov 7, 2024 · 0 comments
Open

Consider environment variable equivalents for some constants #149

costdev opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement New feature or request needs triage needs to be discussed and worked on

Comments

@costdev
Copy link
Contributor

costdev commented Nov 7, 2024

Scenario

A host wants sites to use the host's choice of install/update source.

Current solution

The host can add default values for the existing AspireUpdate constants to wp-config.php.

Problem

Someone with file access, or even a plugin, may accidentally remove the host's constant definitions.

Impact

The site's install/update capability becomes dependent on WordPress.org, which may not be available to the host, or may not have the same packages available as the host's choice.

Additionally, this could lead to time and money spent on raising/handling support requests.

Proposed solution

Add environment variable equivalents for the following constants:

  • AP_ENABLE
  • AP_HOST
  • AP_API_KEY
  • AP_DISABLE_SSL
  • AP_REMOVE_UI

Priority: Constant definitions take priority over environment variables.

This means that hosts can configure defaults which can't be accidentally removed, but can still be intentionally overridden by someone with file access, or by a plugin.

@ipajen ipajen added the needs triage needs to be discussed and worked on label Nov 9, 2024
@costdev costdev added the enhancement New feature or request label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage needs to be discussed and worked on
Projects
None yet
Development

No branches or pull requests

2 participants