From c58b3a13077edd271841541d2b99b82e7bfc1753 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Mon, 5 Feb 2024 12:31:42 -0800 Subject: [PATCH] chore: remove Go We don't have any Go sources in rules_lint so there's no reason we should install a Go toolchain or worry about upgrading it. 'aspect configure' provides the auto-generation for bzl_library targets so we don't need Gazelle either. --- BUILD.bazel | 11 ----------- CONTRIBUTING.md | 2 +- MODULE.bazel | 5 ++--- 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/BUILD.bazel b/BUILD.bazel index 413ce48c..e69de29b 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -1,11 +0,0 @@ -load("@gazelle//:def.bzl", "gazelle", "gazelle_binary") - -gazelle_binary( - name = "gazelle_bin", - languages = ["@bazel_skylib_gazelle_plugin//bzl"], -) - -gazelle( - name = "gazelle", - gazelle = "gazelle_bin", -) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7d4d5356..6bb8e41e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,7 +17,7 @@ Otherwise later tooling on CI may yell at you about formatting/linting violation Some targets are generated from sources. Currently this is just the `bzl_library` targets. -Run `bazel run //:gazelle` to keep them up-to-date. +Run `aspect configure` to keep them up-to-date. ## Using this as a development dependency of other rules diff --git a/MODULE.bazel b/MODULE.bazel index 98586d69..9114d1fa 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -23,7 +23,6 @@ bazel_dep(name = "rules_buf", version = "0.1.1") # Needed due to rules_proto leaking the dependency bazel_dep(name = "protobuf", version = "21.7", repo_name = "com_google_protobuf") -bazel_dep(name = "rules_go", version = "0.39.1", repo_name = "io_bazel_rules_go") -bazel_dep(name = "gazelle", version = "0.31.0", dev_dependency = True) -bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.4.1", dev_dependency = True) +# Needed to get the 'go_context' symbol, to invoke golangci-lint +bazel_dep(name = "rules_go", version = "0.39.1", repo_name = "io_bazel_rules_go")