From 0267f89c64bec2bf44446e8b6adb4408b6325974 Mon Sep 17 00:00:00 2001 From: Jason Bedard Date: Thu, 10 Oct 2024 19:47:21 -0700 Subject: [PATCH] docs(eslint): upgrade ts_project macro notes (#411) --- docs/eslint.md | 8 ++++---- lint/eslint.bzl | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/eslint.md b/docs/eslint.md index 3eca5e26..9c311be3 100644 --- a/docs/eslint.md +++ b/docs/eslint.md @@ -29,11 +29,11 @@ eslint = lint_eslint_aspect( ) ``` -### With ts_project +### With ts_project <=3.2.0 -Note, when used with `ts_project` and a custom `transpiler`, -the macro expands to several targets, -see https://github.com/aspect-build/rules_ts/blob/main/docs/transpiler.md#macro-expansion. +Prior to [commit 5e25e91]https://github.com/aspect-build/rules_ts/commit/5e25e91420947e3a81938d8eb076803e5cf51fe2) +the rule produced by the `ts_project` macro and a custom `transpiler` expanded the macro to +multiple targets, including changing the default target to `js_library`. Since you want to lint the original TypeScript source files, the `ts_project` rule produced by the macro is the one you want to lint, so when used with an `eslint_test` you should use diff --git a/lint/eslint.bzl b/lint/eslint.bzl index 8819dff9..5042be85 100644 --- a/lint/eslint.bzl +++ b/lint/eslint.bzl @@ -27,11 +27,11 @@ eslint = lint_eslint_aspect( ) ``` -### With ts_project +### With ts_project <=3.2.0 -Note, when used with `ts_project` and a custom `transpiler`, -the macro expands to several targets, -see https://github.com/aspect-build/rules_ts/blob/main/docs/transpiler.md#macro-expansion. +Prior to [commit 5e25e91]https://github.com/aspect-build/rules_ts/commit/5e25e91420947e3a81938d8eb076803e5cf51fe2) +the rule produced by the `ts_project` macro and a custom `transpiler` expanded the macro to +multiple targets, including changing the default target to `js_library`. Since you want to lint the original TypeScript source files, the `ts_project` rule produced by the macro is the one you want to lint, so when used with an `eslint_test` you should use