Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: lint: report pass/fail along with exit code #793

Open
alexeagle opened this issue Dec 17, 2024 · 3 comments
Open

[FR]: lint: report pass/fail along with exit code #793

alexeagle opened this issue Dec 17, 2024 · 3 comments
Labels
enhancement New feature or request untriaged Requires traige

Comments

@alexeagle
Copy link
Member

alexeagle commented Dec 17, 2024

What is the current behavior?

running bazel lint / aspect lint produces an exit code that governs how callers (like a CI script) will interpret whether the developer should be blocked. However unless your shell is setup to echo exit codes, this isn't visible.

Describe the feature

Print overall status like ":heavy_white_check: Lint Passed" or ":siren: Lint Failed" at the end of the stdout following the last report.

(note to Aspect: this is requested by a prospective customer)

@alexeagle alexeagle added the enhancement New feature or request label Dec 17, 2024
@github-actions github-actions bot added the untriaged Requires traige label Dec 17, 2024
@fzakaria
Copy link

is this a product of aspect CLI or rules_lint?

@alexeagle
Copy link
Member Author

It's here. rules_lint just has an example shell script as the end-user "driver" DX

@fzakaria
Copy link

I think the distinction is that it's nice to run bazel lint //... on every target whereas the docs outline running it on a sub-package.
Running it on the whole repo prints out a lot obviously as it goes through every package.
I would suspect most people are not interested in the success case and only the failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged Requires traige
Projects
None yet
Development

No branches or pull requests

2 participants