Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution timeout #6

Open
asmblah opened this issue Feb 3, 2014 · 1 comment
Open

Add execution timeout #6

asmblah opened this issue Feb 3, 2014 · 1 comment

Comments

@asmblah
Copy link
Owner

asmblah commented Feb 3, 2014

Infinite loops in the browser can lock up the UI so are a big no-no. Uniter should support the set_time_limit(...) function in order to handle this scenario.

The default of 30 seconds in the Zend engine is too high for in the browser: a default of 1 second should be enforced there.

@asmblah
Copy link
Owner Author

asmblah commented Feb 3, 2014

Added initial draft of PHP execution time limit support in feature/execution-timeout branch.

  • Currently naively hooks 'do...while' and 'while' loops with an expiry check for every iteration
  • Could be improved to only check every N iterations
  • Still need to add support for other loop types, eg. 'for'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant