-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linking userenv
is failing
#27
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
I'll dig out my dusty old Windows machine and investigate this. Haven't even taken a look but if you've got the time, try using the libraries used in SConstruct. |
'userenv.windows.template_release.x86_64.lib' is not a valid library name from Microsoft |
Sounds like it's using the library suffix inherited from Godot when it shouldn't be. Can we define it explicitly with The only reason this lib was included is this comment. What happens if we just drop it for MSVC builds? |
I won't be able to use godot-wasm then because our builds use llvm-mingw. Oh you mean like block msvc, worth a try? Like
|
Sorry still out and about so just spitballing here. I'll take a closer look shortly. I'm definitely not saying we drop your use case! We'll figure it out! |
I think your suggestion worked, when https://github.com/V-Sekai/godot/actions/runs/4899298148/jobs/8749165531 finishes I 'll try to pr. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Amazing! Thanks for doing the legwork here. Feel free to open a similar PR against master for that long overdue contributor credit. Otherwise, I'll cherrypick. |
Closing because issue is resolved. |
Likely related to godotengine/godot#23687. The same issue doesn't affect GDNative/GDExtension addons because I'm overwriting |
userenv
is failing on wasm importuserenv
is failing
This seems like a deficiency of Godot and possibly Scons. Godot changing That said, I've got an idea for a workaround involving Scons |
I went with the Ugly Fuck It Solution™ and added the Windows SDK libs directly to @fire Give it a shot! I've also created #33 to eventually remove dependence on your Godot fork (which has been super helpful ❤️) and provide the engine with Godot Wasm baked in as a module. |
Testing now. Wait an hour :'( |
I'd love to know why Godot 4 builds so much slower. |
Cache doesn't work well when the build never succeeds because it starts from the last cache. (which is empty) |
Hype! The game template passed. Pending game editor. |
Passed. 🎉 |
Great point! Woooooooooooo I see green 🎉🎉🎉 Next builds should be a little faster! Thanks so much for all your help with this! |
I have no idea why. https://github.com/V-Sekai/godot/actions/runs/4897415488/jobs/8745444818
userenv
is failing.https://user-images.githubusercontent.com/32321/236567536-dd3a5a1c-d9e0-4c7d-81cf-4cd23b9dde88.png
The text was updated successfully, but these errors were encountered: